From: Ben Gamari Date: Mon, 4 Nov 2013 20:06:07 +0000 (+1900) Subject: Re: [PATCH 4/4] database: Handle error while deleting uncompacted database X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=61e94136409abbe29a5d406394666743efa7db8b;p=notmuch-archives.git Re: [PATCH 4/4] database: Handle error while deleting uncompacted database --- diff --git a/b3/cee76b1765946e4a2e5edb6bbc1706c9693bf3 b/b3/cee76b1765946e4a2e5edb6bbc1706c9693bf3 new file mode 100644 index 000000000..52548e74c --- /dev/null +++ b/b3/cee76b1765946e4a2e5edb6bbc1706c9693bf3 @@ -0,0 +1,107 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 109FB429E4D + for ; Mon, 4 Nov 2013 12:06:20 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id d7fmVzvwhJvQ for ; + Mon, 4 Nov 2013 12:06:12 -0800 (PST) +Received: from mail-qc0-f179.google.com (mail-qc0-f179.google.com + [209.85.216.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 0CF57429E36 + for ; Mon, 4 Nov 2013 12:06:11 -0800 (PST) +Received: by mail-qc0-f179.google.com with SMTP id k18so4248012qcv.38 + for ; Mon, 04 Nov 2013 12:06:11 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=VrR/+xHPTHqBwJoBVmWNHqeHh6WsHNGkaUpPo0asZ14=; + b=XaY6+cd5f+qGJSDgAU+rgjOhJcPaUxMqumKf8W6yImvcF/YOe5gPHMArZl9Wk4jW+p + +R6Ivj1ApNTrHlWXT40YV6ILiIi4GFGYV1U+IAWwMGZePcM8mvHJh7rAcPq/B0FI5+8v + icILGvZBbHmgnv8z2eCP/MImSFgi5OxdYl3vZcccmcGEEFVg1Q5Nd6T97trARa3DHJbG + +AH8kepP1yi2tCZCFE8mq9vjM0VoNfJ4Ehg7+ukX0CZ+y99X/zGnK/IQeXR94e0IxVaj + 04GONIQNLRBM8s7etKk5V270lIOZEaCfK4nNHPs+Fh6ZEhYOKbtGsbDhQ14CpG6rxvMT + pvDA== +X-Received: by 10.49.30.66 with SMTP id q2mr24593477qeh.38.1383595570458; + Mon, 04 Nov 2013 12:06:10 -0800 (PST) +Received: from localhost (gamari.physics.umass.edu. [128.119.56.223]) + by mx.google.com with ESMTPSA id jw9sm50857040qeb.2.2013.11.04.12.06.09 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Mon, 04 Nov 2013 12:06:09 -0800 (PST) +From: Ben Gamari +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH 4/4] database: Handle error while deleting uncompacted + database +In-Reply-To: <87fvrfrnzy.fsf@zancas.localnet> +References: <1382998997-9938-1-git-send-email-bgamari.foss@gmail.com> + <1382998997-9938-4-git-send-email-bgamari.foss@gmail.com> + <87fvrfrnzy.fsf@zancas.localnet> +User-Agent: Notmuch/0.16+107~g1ef2773 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 04 Nov 2013 15:06:07 -0500 +Message-ID: <87zjpknd8w.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 04 Nov 2013 20:06:20 -0000 + +--=-=-= +Content-Type: text/plain + +David Bremner writes: + +> Ben Gamari writes: +> +>> We never checked to ensure that the rmtree() of the old database +>> succeeded. +>> +> +> Is there some reason these patches (and the existing compact code in the +> lib) is using fprintf and not the status callback function? Most places +> we don't (yet) have logging callbacks, but here we do. +> +Nope. I simply wasn't aware of this infrastructure. I can put together a +patch to fix this. + +Cheers, + +- Ben + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.14 (GNU/Linux) + +iQEcBAEBAgAGBQJSd/4vAAoJEErkyLZmeNiDDgoH/i78hudgxfKzBvru6O7UYots +PbEyHg89Fa3KZbmNWVVlcdS3+ZOA/IMKgJ9JI8j0Qdt0GphLTmRP9PidWLRod9UX +7CqQ70wxrl7BHkyY3xHjt8WjZR/Upb7iFQzeobwpLoc53v3vq7rj2WznEbRxi6AW +ZYpLjxrMMKrq0/tKkM22bzv5SO0r+5YPngDpd3y42kvSCZUlbD86USY7cynH1jAN +xSRh65g4mMKW1sg9naMpETUogV4vw3Kk56qTMkoi6Kt/LcaiuI5u4n4AOI6LfyIQ +lPOOjFy2/rSHqbGVZ7lAkoCikYzfMLK1aM47CmizanJlkguytlKoSQiHFxrgHJo= +=0Gql +-----END PGP SIGNATURE----- +--=-=-=--