From: Mark Walters Date: Mon, 27 May 2013 22:30:37 +0000 (+0100) Subject: Re: [PATCH 0/4] emacs: Part command improvements X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=616cfd151ad332a4c2ff544f5b2a0657b046af09;p=notmuch-archives.git Re: [PATCH 0/4] emacs: Part command improvements --- diff --git a/7f/7aeb5e42724a5ac9dad1f03eb74bdbcfdfe6cc b/7f/7aeb5e42724a5ac9dad1f03eb74bdbcfdfe6cc new file mode 100644 index 000000000..51281b7e3 --- /dev/null +++ b/7f/7aeb5e42724a5ac9dad1f03eb74bdbcfdfe6cc @@ -0,0 +1,117 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id DB51C431FAF + for ; Mon, 27 May 2013 15:30:50 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id KR0pil+fFfTq for ; + Mon, 27 May 2013 15:30:45 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A35B1431FAE + for ; Mon, 27 May 2013 15:30:45 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Uh5w7-0005Mc-5b; Mon, 27 May 2013 23:30:44 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1Uh5w6-0000DD-Si; Mon, 27 May 2013 23:30:39 +0100 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/4] emacs: Part command improvements +In-Reply-To: <1369687594-31774-1-git-send-email-amdragon@mit.edu> +References: <1369687594-31774-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1 + (i486-pc-linux-gnu) +Date: Mon, 27 May 2013 23:30:37 +0100 +Message-ID: <87zjvghx82.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 45b9b14c3ff81e8ea343cc6b3369bac8 (of first 20000 bytes) +X-SpamAssassin-Score: -0.1 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.1 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.1 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 27 May 2013 22:30:51 -0000 + +Austin Clements writes: + +> This is a follow-up of sorts to id:"8761ycc19t.fsf@qmul.ac.uk", where +> Mark suggested that the part handling commands could all use the +> correponding mm-* functions. I ran with the idea and wound up with +> this series, which, in addition to standardizing on the mm-* functions +> for everything and simplifying the implementation overall, decouples +> the part commands from part buttons, which removes an entire layer +> from the implementation and adds the ability to invoke part commands +> with point anywhere in a part (something I often find myself wanting). + +Overall I really like this series. In addition to the clean up etc it +makes it easy to export the text/plain part (which doesn't have a part +button). I have recollection of this being difficult if it is base64 +encoded. + +I have a few small comments + +As mentioned on irc (just included here in case other people are +testing) make-composed-keymap is emacs 24 only. + +This does change the default directory for saving: not serious but it's +probably worth deciding do we want to use mailcap-download-directory or +home or where emacs was started or? + +I don't know if we want to keep a special keymap for the button or just +always use the . prefix; the advantage is that you don't have 's' on a +button acting differently from 's' in the text (which has annoyed me +several times) otoh it is the extra keystroke which may annoy people +too. Let the bikeshedding begin! (obviously return for the default +action would remain. + +Would it be worth having . return in the part body as the default +action ? + +Finally, with message indenting it's the start/end of the part are a +little unclear. I think it's the [ of the part button at the start of +the part to the character before the [ of the next part button. In +particular on the line of a new part but before the button is still the +old part. Since parts are whole lines it would be nice if the region +were line based but I don't know if that is easy. + +Best wishes + +Mark + + +