From: David Edmondson Date: Thu, 11 Feb 2016 08:33:26 +0000 (+0000) Subject: [PATCH v3] (notmuch-show "id:doesnotexist") should not throw an error. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=60e48f804cde122a366f78f082a359c5fe171947;p=notmuch-archives.git [PATCH v3] (notmuch-show "id:doesnotexist") should not throw an error. --- diff --git a/2a/b35d9f2e5ad59933451608468a5d4532bfd1e2 b/2a/b35d9f2e5ad59933451608468a5d4532bfd1e2 new file mode 100644 index 000000000..dd63c84a3 --- /dev/null +++ b/2a/b35d9f2e5ad59933451608468a5d4532bfd1e2 @@ -0,0 +1,109 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 82C906DE0C21 + for ; Thu, 11 Feb 2016 00:33:35 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.121 +X-Spam-Level: +X-Spam-Status: No, score=-0.121 tagged_above=-999 required=5 + tests=[AWL=-0.054, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, + RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, + RCVD_IN_MSPIKE_WL=-0.01, SPF_NEUTRAL=0.652, UNPARSEABLE_RELAY=0.001] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id JQDRISvoO_OX for ; + Thu, 11 Feb 2016 00:33:33 -0800 (PST) +Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com + [74.125.82.43]) by arlo.cworth.org (Postfix) with ESMTPS id 0466F6DE0B36 for + ; Thu, 11 Feb 2016 00:33:33 -0800 (PST) +Received: by mail-wm0-f43.google.com with SMTP id 128so10860881wmz.1 + for ; Thu, 11 Feb 2016 00:33:32 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=dme-org.20150623.gappssmtp.com; s=20150623; + h=from:to:subject:date:message-id; + bh=ETJyAuvbL4fDy3PAL5/xK/7kOfJMicEqYTGMjqSqa5Q=; + b=Oxtl0jjYTE9CiMFYHNATUr8qvCkvhqvs0o0TaQks+jYHSN8ECmM4ej5GOX5zdQd9MV + JSkx6AeBSVZWIPvT7CSnyWNsbWh1IwdifTlOP42uTj/ZzvKLlmotHzP8pUkNSTGKhg2A + pErghIUqdYqOHgZoXFjZv+1AW5fNYQvZlkmWNKcYSLkpTdQYQc6l95dbN8mCBhW2Q0on + p7ALZ9yY/7GRCPpH8r0CSOBXhYU8ZdGrrlsXjhObj5wk2jNNS0niMcWW/R/kXJlRxpxx + SBQ+bdDeRPD6Ld7calJyRVqNJomh/LC1aBx9cY4rdoRtCs5PKAkF2V8hkPAFR3PoYxnF + vvUA== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:date:message-id; + bh=ETJyAuvbL4fDy3PAL5/xK/7kOfJMicEqYTGMjqSqa5Q=; + b=mtjF2QG8pT8c8mJFlkrxDv6aXPIJca378hGjiQTlqNaLzq15pYD/Ox8C33DX7+x2gG + XPR3LkAu/LgJPnPDkI5KKeX4XXeBwkOdQ60u2P99/EdpvhvV03RXe/K/yqRt+JkSnF4a + M7G1CaiDZpNIHcXbxGHhp/5PmG5W7EPGWadxJGMORPDSPSYPaSxCwShnEXFAK752omU8 + p1HKJltblHzeNmKhqEx70gg6yEZmwMBrftvVd5zmHB4ADKoSgqm99y8mCDV/OSYKu26V + H94PgUOhooHAhz4YZzYQNGTLKhTjnxuPPc6abMszPAIJEtd5P96sp4bhSb16u08/Rbqz + 3UMw== +X-Gm-Message-State: + AG10YOQdia5TP3tSmYhz2pT507tk+TkoCnSUELFILAPDpqDcchb87GC9lEa8WSqFPORvtQ== +X-Received: by 10.28.182.136 with SMTP id g130mr16246394wmf.10.1455179610378; + Thu, 11 Feb 2016 00:33:30 -0800 (PST) +Received: from disaster-area.hh.sledj.net + ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) + by smtp.gmail.com with ESMTPSA id e19sm22903696wmd.1.2016.02.11.00.33.28 + for + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Thu, 11 Feb 2016 00:33:28 -0800 (PST) +Received: from localhost (disaster-area.hh.sledj.net [local]) + by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id aed548b7 + for ; Thu, 11 Feb 2016 08:33:27 +0000 (UTC) +From: David Edmondson +To: notmuch@notmuchmail.org +Subject: [PATCH v3] (notmuch-show "id:doesnotexist") should not throw an + error. +Date: Thu, 11 Feb 2016 08:33:26 +0000 +Message-Id: <1455179607-16870-1-git-send-email-dme@dme.org> +X-Mailer: git-send-email 2.1.4 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 11 Feb 2016 08:33:35 -0000 + + +(notmuch-show "id:doesnotexist") should not throw an error. + +This is a followup to id:"874nw0ltwz.fsf@praet.org" and +id:"cuntx91fwaa.fsf@hotblack-desiato.hh.sledj.net". + +The originally proposed change (to have id: links call `notmuch-show' +rather than `notmuch-search') was already made, but the difficulties +with links that generated no results was not addressed. This patch +aims to do that. + +v2: +- Re-worked to `ding' rather than throwing an error. +- Re-jig the relationship between `notmuch-show', + `notmuch-show-refresh-view' and `notmuch-show--build-buffer'. +- Various buffer local variables no longer need to be `permanent-local'. + +v3: +- Comment re-wording. + + +David Edmondson (1): + emacs: Report a lack of matches when calling `notmuch-show'. + + emacs/notmuch-show.el | 144 +++++++++++++++++++++++++++++--------------------- + emacs/notmuch.el | 6 ++- + 2 files changed, 89 insertions(+), 61 deletions(-) + +-- +2.1.4 +