From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Mon, 26 Aug 2013 18:57:39 +0000 (+0300)
Subject: Re: [PATCH] lib: fix clang build
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=60a81306078455f5f38377550a9956bc9f29e959;p=notmuch-archives.git

Re: [PATCH] lib: fix clang build
---

diff --git a/34/4d91be252511075d7513879b6ffcef6b4e2275 b/34/4d91be252511075d7513879b6ffcef6b4e2275
new file mode 100644
index 000000000..e8aaffaea
--- /dev/null
+++ b/34/4d91be252511075d7513879b6ffcef6b4e2275
@@ -0,0 +1,74 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 2857C431FD7
+	for <notmuch@notmuchmail.org>; Mon, 26 Aug 2013 11:57:57 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id GetLd921NDie for <notmuch@notmuchmail.org>;
+	Mon, 26 Aug 2013 11:57:47 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 85AEB431FAF
+	for <notmuch@notmuchmail.org>; Mon, 26 Aug 2013 11:57:47 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 3F32D100030;
+	Mon, 26 Aug 2013 21:57:39 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] lib: fix clang build
+In-Reply-To: <87r4dqesi7.fsf@nikula.org>
+References: <1376775001-16528-1-git-send-email-jani@nikula.org>
+	<m2txim7sjk.fsf@guru.guru-group.fi> <87r4dqesi7.fsf@nikula.org>
+User-Agent: Notmuch/0.16+36~g947c286 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Mon, 26 Aug 2013 21:57:39 +0300
+Message-ID: <m2li3oe0v0.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 26 Aug 2013 18:57:57 -0000
+
+On Sun, Aug 18 2013, Jani Nikula <jani@nikula.org> wrote:
+
+> On Sun, 18 Aug 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
+>>>  
+>>> -typedef struct _notmuch_string_list notmuch_string_list_t;
+>>> -
+>>
+>> anyway, would
+>>
+>> typedef struct visible _notmuch_string_list notmuch_string_list_t;
+>>
+>> have helped here (if yes is your resolution nicer ?? :D )
+>
+> Yes, it would have. Read the commit message! :p
+
+OK! LGTM.
+
+>
+> Jani.
+>
+>> Tomi
+
+Tomi