From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Mon, 14 Apr 2014 12:21:07 +0000 (+0300)
Subject: Re: [PATCH 1/2] build: add canonicalize_file_name to symbols exported	from libnotmuch.so
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=607cb88dc3a6bb4367c05d3738e5f2ae3e7a9eea;p=notmuch-archives.git

Re: [PATCH 1/2] build: add canonicalize_file_name to symbols exported	from libnotmuch.so
---

diff --git a/16/1c1234c9bfa323cef13bdccf7cb08cde2c409d b/16/1c1234c9bfa323cef13bdccf7cb08cde2c409d
new file mode 100644
index 000000000..8afa67e8c
--- /dev/null
+++ b/16/1c1234c9bfa323cef13bdccf7cb08cde2c409d
@@ -0,0 +1,81 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 77390431FBD
+	for <notmuch@notmuchmail.org>; Mon, 14 Apr 2014 05:21:22 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id BgfAkaXZhMYZ for <notmuch@notmuchmail.org>;
+	Mon, 14 Apr 2014 05:21:16 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 7E3FB431FBC
+	for <notmuch@notmuchmail.org>; Mon, 14 Apr 2014 05:21:16 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 352A610008F;
+	Mon, 14 Apr 2014 15:21:08 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 1/2] build: add canonicalize_file_name to symbols
+	exported	from libnotmuch.so
+In-Reply-To: <1397042643-10975-1-git-send-email-david@tethera.net>
+References: <87r4586p7m.fsf@zancas.localnet>
+	<1397042643-10975-1-git-send-email-david@tethera.net>
+User-Agent: Notmuch/0.17+200~g5c6d42d (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Mon, 14 Apr 2014 15:21:07 +0300
+Message-ID: <m24n1wumoc.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 14 Apr 2014 12:21:22 -0000
+
+On Wed, Apr 09 2014, David Bremner <david@tethera.net> wrote:
+
+> This is needed for our compat version of canonicalize_file_name to be used.
+> ---
+
+This series LGTM, just that this does not apply anymore (2nd patch, that is).
+
+>  lib/gen-version-script.sh | 2 +-
+>  1 file changed, 1 insertion(+), 1 deletion(-)
+>
+> diff --git a/lib/gen-version-script.sh b/lib/gen-version-script.sh
+> index 76670d5..64a7374 100644
+> --- a/lib/gen-version-script.sh
+> +++ b/lib/gen-version-script.sh
+> @@ -23,6 +23,6 @@ while read sym; do
+>  	    ;;
+>      esac
+>  done
+> -nm $* | awk '$1 ~ "^[0-9a-fA-F][0-9a-fA-F]*$" && $2 == "T" && $3 ~ "^get(line|delim)$" {print $3 ";"}'
+> +nm $* | awk '$1 ~ "^[0-9a-fA-F][0-9a-fA-F]*$" && $2 == "T" && $3 ~ "^(getline|getdelim|canonicalize_file_name)$" {print $3 ";"}'
+>  sed  -n 's/^[[:space:]]*\(notmuch_[a-z_]*\)[[:space:]]*(.*/ \1;/p' $HEADER
+>  printf "local: *;\n};\n"
+> -- 
+> 1.9.0
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch