From: Jani Nikula Date: Wed, 23 Sep 2015 18:56:11 +0000 (+0300) Subject: Re: [PATCH 3½/9] test: notmuch address --deduplicate=no tests X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=5f7cc111be5f8a23ba2970760ab2515659324194;p=notmuch-archives.git Re: [PATCH 3½/9] test: notmuch address --deduplicate=no tests --- diff --git a/d9/627ca37787ca8a57e750d69bcd91fc1fc78f83 b/d9/627ca37787ca8a57e750d69bcd91fc1fc78f83 new file mode 100644 index 000000000..f08789c4a --- /dev/null +++ b/d9/627ca37787ca8a57e750d69bcd91fc1fc78f83 @@ -0,0 +1,124 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 1273B6DE1479 + for ; Wed, 23 Sep 2015 11:56:34 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.144 +X-Spam-Level: +X-Spam-Status: No, score=-0.144 tagged_above=-999 required=5 + tests=[AWL=-0.168, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, + RCVD_IN_MSPIKE_WL=-0.01, URIBL_SBL=0.644, URIBL_SBL_A=0.1] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id QkI9UY90aOqt for ; + Wed, 23 Sep 2015 11:56:32 -0700 (PDT) +Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com + [209.85.212.176]) + by arlo.cworth.org (Postfix) with ESMTPS id A60026DE143A + for ; Wed, 23 Sep 2015 11:56:31 -0700 (PDT) +Received: by wiclk2 with SMTP id lk2so253472086wic.0 + for ; Wed, 23 Sep 2015 11:56:30 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=mjHXvEYGY1ZJrd3UAFQ+gAa6xvbqx7Keg9XZwwfZ7k8=; + b=StEfazSstN8fSsUCbwfu2FzH2g2EK4S9CQ5gAgikiDEKFIc+imk7sV/PVwqtA4+pZc + mDGHA5TvABrn8TlwJWEy4u0RfGUTwQogNZKHM2ykToUaHHGtVI32b2YDnnKDxuqBDnv1 + WCx92kLo6ZDLybNqUpgwzUb4ca1PNMkfFPvXx9al2aoLRekM5o0PjEvNRdiLgxNhY5bZ + bXU9ZrRicz4ADEs6Oih1dNpyWr7y33rFx5nEVAiDR+eqA6PDvNixXw3mxpBuesiOWgD0 + iTFlqFdt+s1iTvL9gKg5T7MgRN3n5419nZyFOERTc5uiVsENqbtTlLgBX7jYWIE8qBvA + /l6w== +X-Gm-Message-State: + ALoCoQmqIbfobOsIT837lbd5u5M4Rgjjy2Sa4HB6gLQff2VrUQ4ydF3a8nhxxysfmFjx1JXS/MGc +X-Received: by 10.180.8.200 with SMTP id t8mr5756474wia.34.1443034589978; + Wed, 23 Sep 2015 11:56:29 -0700 (PDT) +Received: from localhost (mobile-access-bcee4f-131.dhcp.inet.fi. + [188.238.79.131]) + by smtp.gmail.com with ESMTPSA id ly4sm8643103wjb.4.2015.09.23.11.56.29 + (version=TLSv1/SSLv3 cipher=OTHER); + Wed, 23 Sep 2015 11:56:29 -0700 (PDT) +From: Jani Nikula +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH =?utf-8?Q?3=C2=BD=2F9=5D?= test: notmuch address + --deduplicate=no tests +In-Reply-To: <87a8shtg4w.fsf@maritornes.cs.unb.ca> +References: + + <1441391716-17282-1-git-send-email-jani@nikula.org> + <87a8shtg4w.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.20.2+66~gb33abd9 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Wed, 23 Sep 2015 21:56:11 +0300 +Message-ID: <87mvwddkxg.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 23 Sep 2015 18:56:34 -0000 + +On Sun, 20 Sep 2015, David Bremner wrote: +> Jani Nikula writes: +> +>> Test not using address deduplication. Incorporate some trivial output +>> sorting tests here, as they seem to lack tests. +>> --- +>> test/T095-address.sh | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++ +>> 1 file changed, 70 insertions(+) +>> +>> diff --git a/test/T095-address.sh b/test/T095-address.sh +>> index 8eecb2a6a7ba..f8d902cb3a5e 100755 +>> --- a/test/T095-address.sh +>> +++ b/test/T095-address.sh +>> @@ -145,4 +145,74 @@ cat <EXPECTED +>> EOF +>> test_expect_equal_file OUTPUT EXPECTED +>> +>> +test_begin_subtest "--deduplicate=no --sort=oldest-first --output=sender" +>> +notmuch address --deduplicate=no --sort=oldest-first --output=sender '*' >OUTPUT +>> +cat <EXPECTED +>> +Mikhail Gusarov +>> +Mikhail Gusarov +>> +Carl Worth +> +>> + +>> +test_begin_subtest "--deduplicate=no --sort=newest-first --output=sender --output=recipients" +>> +notmuch address --deduplicate=no --sort=newest-first --output=sender --output=recipients path:foo/new >OUTPUT +>> +cat <EXPECTED +>> +Mikhail Gusarov +>> +notmuch@notmuchmail.org +>> +Mikhail Gusarov +> +> Two comments: +> +> 1) It's suprising that Mikail is first in both the newest-first and +> oldest-first list. Is it easy to explain why? +> +> 2) the use of path: term is not mentioned in the description. Should it +> be mentioned somehow? + +I wanted to have a smaller set of results in the second test, and path: +was an easy filter so I could look at the files there to construct the +expected results. That also explains the first part; it just so happened +that the folder I arbitrarily picked happened to have Mikail there. + +BR, +Jani. + + +> +> d