From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Wed, 5 Nov 2014 20:57:54 +0000 (+0200)
Subject: Re: [PATCH v3 09/10] cli: address: Add --output=count
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=5e4a95e4471904997100f5edde5520e01e177ec0;p=notmuch-archives.git

Re: [PATCH v3 09/10] cli: address: Add --output=count
---

diff --git a/f2/814ec1afa144ca17949b376afe8d3da4d31fbb b/f2/814ec1afa144ca17949b376afe8d3da4d31fbb
new file mode 100644
index 000000000..2dbe35dca
--- /dev/null
+++ b/f2/814ec1afa144ca17949b376afe8d3da4d31fbb
@@ -0,0 +1,80 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1958B431FAF
+	for <notmuch@notmuchmail.org>; Wed,  5 Nov 2014 12:58:33 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id Y5FWkzwJsn6l for <notmuch@notmuchmail.org>;
+	Wed,  5 Nov 2014 12:58:25 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 22BB8431FAE
+	for <notmuch@notmuchmail.org>; Wed,  5 Nov 2014 12:58:25 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 8EE9C100033;
+	Wed,  5 Nov 2014 22:57:54 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v3 09/10] cli: address: Add --output=count
+In-Reply-To: <1415147159-19946-10-git-send-email-sojkam1@fel.cvut.cz>
+References: <1415147159-19946-1-git-send-email-sojkam1@fel.cvut.cz>
+	<1415147159-19946-10-git-send-email-sojkam1@fel.cvut.cz>
+User-Agent: Notmuch/0.18.2+169~g5bcdd1c (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Wed, 05 Nov 2014 22:57:54 +0200
+Message-ID: <m21tph1i25.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Wed, 05 Nov 2014 20:58:33 -0000
+
+On Wed, Nov 05 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
+
+> This output prints how many times was each address encountered during
+> search.
+> ---
+> [ nn lines removed]
+>
+>      ``--sort=``\ (**newest-first**\ \|\ **oldest-first**)
+>          This option can be used to present results in either
+>          chronological order (**oldest-first**) or reverse chronological
+> @@ -56,6 +63,8 @@ Supported options for **address** include
+>          By default, results will be displayed in reverse chronological
+>          order, (that is, the newest results will be displayed first).
+>  
+> +	This option has no effect when used with --output=count.
+
+This is not entirely true -- the order the addresses are gathered will
+affect how the hash table is built up and it may affect how the addresses
+are printed (unless the --sort option is ignored when --count is given,
+which does not seem to be the case). 
+
+The question is whether the accuracy of this message matters; some
+nitpickers might complain ;)
+
+Anyway, +1 from me to patches 1 - 9 -- these things could still be
+adjusted when NEWS patch of the feature is prepared.
+
+
+Tomi