From: Timo Hirvonen <tihirvon@gmail.com>
Date: Sun, 25 Jun 2006 11:28:19 +0000 (+0300)
Subject: Don't xcalloc() struct diffstat_t
X-Git-Tag: v1.4.2-rc1~85^2~13
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=5e2b0636c709884e45ef941cd4514c225f204982;p=git.git

Don't xcalloc() struct diffstat_t

Signed-off-by: Timo Hirvonen <tihirvon@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/diff.c b/diff.c
index 491b846f6..54698f511 100644
--- a/diff.c
+++ b/diff.c
@@ -2115,17 +2115,16 @@ void diff_flush(struct diff_options *options)
 	}
 
 	if (output_format & DIFF_FORMAT_DIFFSTAT) {
-		struct diffstat_t *diffstat;
+		struct diffstat_t diffstat;
 
-		diffstat = xcalloc(sizeof (struct diffstat_t), 1);
-		diffstat->xm.consume = diffstat_consume;
+		memset(&diffstat, 0, sizeof(struct diffstat_t));
+		diffstat.xm.consume = diffstat_consume;
 		for (i = 0; i < q->nr; i++) {
 			struct diff_filepair *p = q->queue[i];
 			if (check_pair_status(p))
-				diff_flush_stat(p, options, diffstat);
+				diff_flush_stat(p, options, &diffstat);
 		}
-		show_stats(diffstat);
-		free(diffstat);
+		show_stats(&diffstat);
 	}
 
 	if (output_format & DIFF_FORMAT_SUMMARY) {