From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Tue, 7 Apr 2009 01:09:12 +0000 (-0400)
Subject: more portable perl-based simple_checksum; i think this is correct, but i welcome... 
X-Git-Tag: monkeysphere_0.25~31^2~13
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=5df09d935f33477cdd9763c0e9c1ba7c8073aea0;p=monkeysphere.git

more portable perl-based simple_checksum; i think this is correct, but i welcome any pointers about what i might be getting wrong.
---

diff --git a/src/share/keytrans b/src/share/keytrans
index 8b2e2ea..e6777ff 100755
--- a/src/share/keytrans
+++ b/src/share/keytrans
@@ -195,11 +195,11 @@ my $keyserver_prefs = { nomodify => 0x80
 ########### Math/Utility Functions ##############
 
 
-# see the bottom of page 43 of RFC 4880
+# see the bottom of page 44 of RFC 4880 (http://tools.ietf.org/html/rfc4880#page-44)
 sub simple_checksum {
   my $bytes = shift;
 
-  return unpack("%32W*",$bytes) % 65536;
+  return unpack("%16C*",$bytes);
 }
 
 # calculate the multiplicative inverse of a mod b this is euclid's