From: David Bremner Date: Sat, 26 Oct 2013 00:13:45 +0000 (+2100) Subject: Re: [PATCH v2] new: Don't scan unchanged directories with no sub-directories X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=5d1d22b8e535d1c56ed06fd6c450639893ef49c0;p=notmuch-archives.git Re: [PATCH v2] new: Don't scan unchanged directories with no sub-directories --- diff --git a/4f/547c4ca37b06ae87e4a8c320e74f957cd5d30b b/4f/547c4ca37b06ae87e4a8c320e74f957cd5d30b new file mode 100644 index 000000000..4bd0637f1 --- /dev/null +++ b/4f/547c4ca37b06ae87e4a8c320e74f957cd5d30b @@ -0,0 +1,76 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3117E431FD2 + for ; Fri, 25 Oct 2013 17:13:58 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id tZ-M7v5p4aGw for ; + Fri, 25 Oct 2013 17:13:53 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 70067431FC7 + for ; Fri, 25 Oct 2013 17:13:53 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1VZrVm-0001Rk-EN; Fri, 25 Oct 2013 21:13:50 -0300 +Received: (nullmailer pid 31345 invoked by uid 1000); Sat, 26 Oct 2013 + 00:13:45 -0000 +From: David Bremner +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH v2] new: Don't scan unchanged directories with no + sub-directories +In-Reply-To: <1382650739-12438-1-git-send-email-amdragon@mit.edu> +References: <20131024210837.GH20337@mit.edu> + <1382650739-12438-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.16+97~g6878b0b (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Fri, 25 Oct 2013 21:13:45 -0300 +Message-ID: <878uxgvqh2.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 26 Oct 2013 00:13:58 -0000 + +Austin Clements writes: + +> This can substantially reduce the cost of notmuch new in some +> situations, such as when the file system cache is cold or when the +> Maildir is on NFS. + +On my desktop at home (a core i7 950) with spinning rust disks (and lvm +on luks) this patch yields about a 7% slowdown in the intial new perf +test + +from + + Wall(s) Usr(s) Sys(s) Res(K) In/Out(512B) + Initial notmuch new 579.60 348.86 14.26 217188 5330266/3501272 + +to + + Wall(s) Usr(s) Sys(s) Res(K) In/Out(512B) + Initial notmuch new 620.51 368.62 15.48 217156 5330354/3416456 + +On an SSD I don't detect a significant different (<0.5% speedup) + +d