From: Greg Hudson <ghudson@mit.edu>
Date: Thu, 8 Oct 2009 12:59:33 +0000 (+0000)
Subject: In krb5_c_verify_checksum, avoid the structure copy of *data since we
X-Git-Tag: krb5-1.8-alpha1~312
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=5cb04ac7d0afa3764da0b79bc12a6653645c60f7;p=krb5.git

In krb5_c_verify_checksum, avoid the structure copy of *data since we
don't care about data->magic.  Squashes a bunch of unimportant
Coverity defects.  (May not be the correct long-term solution.)

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@22868 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/lib/crypto/krb/verify_checksum.c b/src/lib/crypto/krb/verify_checksum.c
index ae15cc872..4466c7dad 100644
--- a/src/lib/crypto/krb/verify_checksum.c
+++ b/src/lib/crypto/krb/verify_checksum.c
@@ -59,7 +59,8 @@ krb5_c_verify_checksum(krb5_context context, const krb5_keyblock *key,
 	    krb5_crypto_iov iov[1];
 
 	    iov[0].flags = KRB5_CRYPTO_TYPE_DATA;
-	    iov[0].data = *data;
+	    iov[0].data.data = data->data;
+	    iov[0].data.length = data->length;
 
 	    return (*keyhash->verify_iov)(key, usage, 0, iov, 1, &indata,
 					  valid);