From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sun, 6 Sep 2015 09:23:57 +0000 (+0300)
Subject: Re: [PATCH 1/2] test: fix whitespace/indentation in symbol-test
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=5c0591e943a83ac6b333ed01c45480ca7cac2c6f;p=notmuch-archives.git

Re: [PATCH 1/2] test: fix whitespace/indentation in symbol-test
---

diff --git a/3e/ca1828b0a33e62ac46f74521e71da47f643ea4 b/3e/ca1828b0a33e62ac46f74521e71da47f643ea4
new file mode 100644
index 000000000..c34b2ff7d
--- /dev/null
+++ b/3e/ca1828b0a33e62ac46f74521e71da47f643ea4
@@ -0,0 +1,113 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 399286DE1AEA
+ for <notmuch@notmuchmail.org>; Sun,  6 Sep 2015 02:25:27 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.807
+X-Spam-Level: 
+X-Spam-Status: No, score=0.807 tagged_above=-999 required=5 tests=[AWL=0.155, 
+ SPF_NEUTRAL=0.652] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id 5nlXCF0pOJbo for <notmuch@notmuchmail.org>;
+ Sun,  6 Sep 2015 02:25:24 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id 596D46DE1AD8
+ for <notmuch@notmuchmail.org>; Sun,  6 Sep 2015 02:25:24 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id 03268100033;
+ Sun,  6 Sep 2015 12:23:58 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 1/2] test: fix whitespace/indentation in symbol-test
+In-Reply-To: <1441392555-20056-1-git-send-email-jani@nikula.org>
+References: <1441392555-20056-1-git-send-email-jani@nikula.org>
+User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sun, 06 Sep 2015 12:23:57 +0300
+Message-ID: <m2k2s3295e.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.18
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 06 Sep 2015 09:25:27 -0000
+
+On Fri, Sep 04 2015, Jani Nikula <jani@nikula.org> wrote:
+
+> Not of much consequence, but makes it nicer to do further edits.
+> ---
+
+These 2 patches LGTM ! +1! :D
+
+>  test/symbol-test.cc | 34 ++++++++++++++++++----------------
+>  1 file changed, 18 insertions(+), 16 deletions(-)
+>
+> diff --git a/test/symbol-test.cc b/test/symbol-test.cc
+> index fb77b418a1a8..77dbc1af44b2 100644
+> --- a/test/symbol-test.cc
+> +++ b/test/symbol-test.cc
+> @@ -3,23 +3,25 @@
+>  #include <xapian.h>
+>  #include <notmuch.h>
+>  
+> +int main (int argc, char** argv)
+> +{
+> +    notmuch_database_t *notmuch;
+> +    char *message = NULL;
+>  
+> -int main(int argc, char** argv) {
+> -  notmuch_database_t *notmuch;
+> -  char *message = NULL;
+> +    if (notmuch_database_open_verbose (argv[1], NOTMUCH_DATABASE_MODE_READ_ONLY,
+> +				       &notmuch, &message)) {
+> +	if (message) {
+> +	    fputs (message, stderr);
+> +	    free (message);
+> +	}
+> +    }
+>  
+> -  if (notmuch_database_open_verbose  (argv[1], NOTMUCH_DATABASE_MODE_READ_ONLY, &notmuch, &message))
+> -      if (message) {
+> -	  fputs (message, stderr);
+> -	  free (message);
+> -      }
+> +    try {
+> +	(void) new Xapian::WritableDatabase (argv[2], Xapian::DB_OPEN);
+> +    } catch (const Xapian::Error &error) {
+> +	printf("caught %s\n", error.get_msg().c_str());
+> +	return 0;
+> +    }
+>  
+> -  try {
+> -    (void) new Xapian::WritableDatabase(argv[2], Xapian::DB_OPEN);
+> -  } catch (const Xapian::Error &error) {
+> -    printf("caught %s\n", error.get_msg().c_str());
+> -    return 0;
+> -  }
+> -
+> -  return 1;
+> +    return 1;
+>  }
+> -- 
+> 2.1.4
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch