From: David Bremner <david@tethera.net>
Date: Fri, 26 Sep 2014 20:09:16 +0000 (+0200)
Subject: Re: [PATCH 09/11] cli/insert: add fail path to add_file_to_database
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=5bbeda34bf38b2563d8a141ed3241e0098b21d07;p=notmuch-archives.git

Re: [PATCH 09/11] cli/insert: add fail path to add_file_to_database
---

diff --git a/c7/f83b672c9218e79d25f8c8452173080f22fdfd b/c7/f83b672c9218e79d25f8c8452173080f22fdfd
new file mode 100644
index 000000000..95686d719
--- /dev/null
+++ b/c7/f83b672c9218e79d25f8c8452173080f22fdfd
@@ -0,0 +1,71 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 190EA431FB6
+	for <notmuch@notmuchmail.org>; Fri, 26 Sep 2014 13:09:35 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id T51JSThpj0WA for <notmuch@notmuchmail.org>;
+	Fri, 26 Sep 2014 13:09:31 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 4F58C431FAF
+	for <notmuch@notmuchmail.org>; Fri, 26 Sep 2014 13:09:31 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1XXbpR-0000ZR-I9; Fri, 26 Sep 2014 17:09:21 -0300
+Received: (nullmailer pid 9379 invoked by uid 1000); Fri, 26 Sep 2014
+	20:09:16 -0000
+From: David Bremner <david@tethera.net>
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 09/11] cli/insert: add fail path to add_file_to_database
+In-Reply-To:
+ <5089ce31afa0ba764520270af1e680a4ab50b4e6.1411379395.git.jani@nikula.org>
+References: <cover.1411379395.git.jani@nikula.org>
+	<5089ce31afa0ba764520270af1e680a4ab50b4e6.1411379395.git.jani@nikula.org>
+User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Fri, 26 Sep 2014 22:09:16 +0200
+Message-ID: <87eguyf8k3.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 26 Sep 2014 20:09:35 -0000
+
+Jani Nikula <jani@nikula.org> writes:
+
+
+> +	status = notmuch_message_tags_to_maildir_flags (message);
+
+...
+
+> +	/*
+> +	 * Note: Unfortunately a failed maildir flag sync might
+> +	 * already have renamed the file, in which case the cleanup
+> +	 * path will fail.
+> +	 */
+
+I'd like to be more explicit about what potentially bad outcomes there
+are here.  I guess this message file gets left on disk, unindexed,
+perhaps forever if the user never runs notmuch new? Would it make sense
+to suggest the user run notmuch new to "recover" these message files?
+