From: Jani Nikula Date: Fri, 17 Oct 2014 08:34:45 +0000 (+0300) Subject: Re: [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=5afdf9267fc399541855269848caf924f60826ac;p=notmuch-archives.git Re: [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures --- diff --git a/47/70b5da64b9626df03bdb5978ecdcf3ee4f82d0 b/47/70b5da64b9626df03bdb5978ecdcf3ee4f82d0 new file mode 100644 index 000000000..a21aaae30 --- /dev/null +++ b/47/70b5da64b9626df03bdb5978ecdcf3ee4f82d0 @@ -0,0 +1,123 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 242BC431FB6 + for ; Fri, 17 Oct 2014 01:34:59 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id duFOValUQ7Zx for ; + Fri, 17 Oct 2014 01:34:51 -0700 (PDT) +Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com + [74.125.82.44]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 55B72431FAF for ; Fri, 17 Oct 2014 01:34:51 -0700 + (PDT) +Received: by mail-wg0-f44.google.com with SMTP id y10so378526wgg.3 + for ; Fri, 17 Oct 2014 01:34:49 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=HbMZmpgdlCR7ymiLfoLMoiL4Oljso4/Eo2IIvETbRKA=; + b=l3roD5nV424bEmoeHkYgpAUXobNYq8zObthb4Ma6oUgbLot7dc4ui7q3wAl41k2ea7 + psh3epIX4Ty9oZGbfuhZ+Jx9m+m+Tg8+j5xdMo0NSm5kvNXlvh4xcYnLMUfvWpw2Frox + litzKbiFc2dPU567Vyu3rZ5tsYsG+OE7cvE98EDJEkqWGKKkPKAoHHcm2KLbpg+UcWRX + +1Ear5gsr0I0NxBLkJsLzTjjjz9eprSNCkcL69e1vsO+WxH1jWkRsrJJzRyq1xu28XIt + znvp9yZn1Lc3E1mrL8q8FS1m8QkgbpS5VUb1qki6LkVaiEc7R+d9kJtspLd/6QFeNF/A + M/oQ== +X-Gm-Message-State: + ALoCoQlkuCkL+9nU6djJr4LS5qro3AqqTSVxrEbH7MY/cyXkC9rnH2vL9/PbMzcPZJBw2BjRxw91 +X-Received: by 10.180.14.196 with SMTP id r4mr11853835wic.33.1413534888803; + Fri, 17 Oct 2014 01:34:48 -0700 (PDT) +Received: from localhost (mobile-internet-5d6ad2-138.dhcp.inet.fi. + [93.106.210.138]) + by mx.google.com with ESMTPSA id q5sm798323wja.49.2014.10.17.01.34.47 + for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Fri, 17 Oct 2014 01:34:48 -0700 (PDT) +From: Jani Nikula +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [Patch v2.5 1/4] test/insert: add known broken tests for + indexing failures +In-Reply-To: <1412371140-21051-2-git-send-email-david@tethera.net> +References: <1412371140-21051-1-git-send-email-david@tethera.net> + <1412371140-21051-2-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.18.1+65~g9f0f30f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Fri, 17 Oct 2014 11:34:45 +0300 +Message-ID: <87siin2ixm.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 17 Oct 2014 08:34:59 -0000 + +On Sat, 04 Oct 2014, David Bremner wrote: +> These tests are written with the assumption that we want all indexing +> failures to be considered as failures by notmuch insert. + +Just realized this needs a missing prereq test for gdb. + +BR, +Jani. + + +> --- +> test/T070-insert.sh | 22 ++++++++++++++++++++++ +> 1 file changed, 22 insertions(+) +> +> diff --git a/test/T070-insert.sh b/test/T070-insert.sh +> index ea9db07..40a7636 100755 +> --- a/test/T070-insert.sh +> +++ b/test/T070-insert.sh +> @@ -183,4 +183,26 @@ test_expect_code 1 "Invalid tags set exit code" \ +> +> notmuch config set new.tags $OLDCONFIG +> +> +# DUPLICATE_MESSAGE_ID is not tested here, because it should actually pass. +> + +> +for code in OUT_OF_MEMORY XAPIAN_EXCEPTION FILE_NOT_EMAIL \ +> + READ_ONLY_DATABASE UPGRADE_REQUIRED; do +> +gen_insert_msg +> +cat < index-file-$code.gdb +> +file notmuch +> +set breakpoint pending on +> +break notmuch_database_add_message +> +commands +> +return NOTMUCH_STATUS_$code +> +continue +> +end +> +run +> +EOF +> +test_begin_subtest "error exit when add_message returns $code" +> +test_subtest_known_broken +> +gdb --batch-silent --return-child-result -x index-file-$code.gdb \ +> + --args notmuch insert < $gen_msg_filename +> +test_expect_equal $? 1 +> +done +> + +> test_done +> -- +> 2.1.0 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch