From: Zac Medico Date: Sat, 10 Nov 2007 17:31:08 +0000 (-0000) Subject: Make the EbuildQuote.missing_quotes regex accept single X-Git-Tag: v2.2_pre1~407 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=5a99498c199dc8246082af6386e943d7920b020e;p=portage.git Make the EbuildQuote.missing_quotes regex accept single quotes where it accepts double quotes in order to eliminate some false positives. Thanks to Krzysiek Pawlik for reporting. svn path=/main/trunk/; revision=8485 --- diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index 63a097501..916003e7e 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -78,8 +78,8 @@ class EbuildQuote(LineCheck): var_names = r'(D|S|T|ROOT|FILESDIR|WORKDIR)' var_reference = re.compile(r'\$(\{'+var_names+'\}|' + \ var_names + '\W)') - missing_quotes = re.compile(r'(\s|^)[^"\s]*\$\{?' + var_names + \ - r'\}?[^"\s]*(\s|$)') + missing_quotes = re.compile(r'(\s|^)[^"\'\s]*\$\{?' + var_names + \ + r'\}?[^"\'\s]*(\s|$)') cond_begin = re.compile(r'(^|\s+)\[\[($|\\$|\s+)') cond_end = re.compile(r'(^|\s+)\]\]($|\\$|\s+)')