From: Mark Walters Date: Sat, 10 May 2014 08:30:49 +0000 (+0100) Subject: Re: [PATCH v2] emacs: Improve the cited message included in replies X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=59e9064142077b9c7d3ede030a0ec77f9905f6dd;p=notmuch-archives.git Re: [PATCH v2] emacs: Improve the cited message included in replies --- diff --git a/34/767b8a1ef89c6c29d4d3dab4a9219cf512e262 b/34/767b8a1ef89c6c29d4d3dab4a9219cf512e262 new file mode 100644 index 000000000..bb00dfdc3 --- /dev/null +++ b/34/767b8a1ef89c6c29d4d3dab4a9219cf512e262 @@ -0,0 +1,102 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 39FEF431FC0 + for ; Sat, 10 May 2014 01:31:24 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.502 +X-Spam-Level: +X-Spam-Status: No, score=0.502 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id jirxVQ930Sik for ; + Sat, 10 May 2014 01:30:59 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id D9AAE431FBF + for ; Sat, 10 May 2014 01:30:58 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Wj2gE-0005NK-Ee; Sat, 10 May 2014 09:30:51 +0100 +Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1Wj2gE-0004X6-5D; Sat, 10 May 2014 09:30:50 +0100 +From: Mark Walters +To: David Edmondson , notmuch@notmuchmail.org +Subject: Re: [PATCH v2] emacs: Improve the cited message included in replies +In-Reply-To: <1399530272-11857-1-git-send-email-dme@dme.org> +References: <1399482846-25308-1-git-send-email-dme@dme.org> + <1399530272-11857-1-git-send-email-dme@dme.org> +User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 10 May 2014 09:30:49 +0100 +Message-ID: <87ha4y8286.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 87.81.223.162 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 7d5b0a9bc4e827920942979c58224985 (of first 20000 bytes) +X-SpamAssassin-Score: -0.1 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.1 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.1 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 10 May 2014 08:31:24 -0000 + +On Thu, 08 May 2014, David Edmondson wrote: +> emacs: Improve the cited message included in replies +> +> v2: +> - Don't run the text/plain hooks when generating the message to quote. +> + +In principle I like this approach: keeping show and reply closely linked +seems good. + +At the moment, as you say, the tests don't all pass. The first reason is +that this puts in buttons for the parts. Stopping that happening is not +completely trivial as we need to make sure that the instruction gets +passed down to sub-parts of multiparts etc. (You could argue that the +'no-button option to notmuch-show-insert-bodypart is buggy as it only +stops the top level button for the part) + +Secondly, the existing code only includes text sub-parts of the +message. I would think your version might include any sub-parts show is +configured to display, including, say images. (However, in my testing +images didn't seem to be included: I am not sure why.) + +I can't tell how much work it is to modify show to take account of these +things, so am not sure if this is the best approach, or just adding +something to deal with rfc822 to our existing reply code is easier. + +Best wishes + +Mark +