From: David Bremner Date: Mon, 20 May 2013 18:04:27 +0000 (+2100) Subject: Re: [PATCH 1/2] contrib: pick: move save-excursion closer to message insertion X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=59b0fa540a027987cf1344d66b6774ffe7dcfa85;p=notmuch-archives.git Re: [PATCH 1/2] contrib: pick: move save-excursion closer to message insertion --- diff --git a/d6/ae02747761d45034a776aa5badfcf0135912f7 b/d6/ae02747761d45034a776aa5badfcf0135912f7 new file mode 100644 index 000000000..289e8754c --- /dev/null +++ b/d6/ae02747761d45034a776aa5badfcf0135912f7 @@ -0,0 +1,69 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E519C431FBC + for ; Mon, 20 May 2013 11:04:44 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id EpBJK9cN7jTp for ; + Mon, 20 May 2013 11:04:38 -0700 (PDT) +Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id F3D5D431FB6 + for ; Mon, 20 May 2013 11:04:37 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r4KI4Xu9017657; + Mon, 20 May 2013 15:04:34 -0300 +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1UeURl-00007X-HN; Mon, 20 May 2013 15:04:33 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1UeURf-0004Lw-T8; Mon, 20 May 2013 15:04:27 -0300 +From: David Bremner +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] contrib: pick: move save-excursion closer to message + insertion +In-Reply-To: <1357814477-1348-2-git-send-email-markwalters1009@gmail.com> +References: <1357814477-1348-1-git-send-email-markwalters1009@gmail.com> + <1357814477-1348-2-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.15.2+105~ge63aa66 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 20 May 2013 15:04:27 -0300 +Message-ID: <8738thr0ic.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 20 May 2013 18:04:45 -0000 + +Mark Walters writes: + +> Pick keeps point roughly at the top of the buffer while inserting +> messages at the end as they come in (from the async +> parser). Previously the save-excursion to do this was done once for +> each thread inserted: now it is done for each individual message. + +pushed this, and revised #2