From: David Rientjes <rientjes@google.com>
Date: Mon, 14 Aug 2006 20:40:51 +0000 (-0700)
Subject: Make upload_pack void and remove conditional return.
X-Git-Tag: v1.4.3-rc1~241
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=59076eba6e1a41c2e0032dbd656d8429e9655358;p=git.git

Make upload_pack void and remove conditional return.

Signed-off-by: David Rientjes <rientjes@google.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/upload-pack.c b/upload-pack.c
index bbd6bd60b..27e2abe36 100644
--- a/upload-pack.c
+++ b/upload-pack.c
@@ -459,18 +459,17 @@ static int send_ref(const char *refname, const unsigned char *sha1)
 	return 0;
 }
 
-static int upload_pack(void)
+static void upload_pack(void)
 {
 	reset_timeout();
 	head_ref(send_ref);
 	for_each_ref(send_ref);
 	packet_flush(1);
 	receive_needs();
-	if (!want_obj.nr)
-		return 0;
-	get_common_commits();
-	create_pack_file();
-	return 0;
+	if (want_obj.nr) {
+		get_common_commits();
+		create_pack_file();
+	}
 }
 
 int main(int argc, char **argv)