From: Jonathan Nieder Date: Sat, 6 Nov 2010 11:44:11 +0000 (-0500) Subject: wrapper: move xmmap() to sha1_file.c X-Git-Tag: v1.7.4-rc0~89^2~6 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=58ecbd5edeb2357c313db75bc49d45981a2061b7;p=git.git wrapper: move xmmap() to sha1_file.c wrapper.o depends on sha1_file.o for a number of reasons. One is release_pack_memory(). xmmap function calls mmap, discarding unused pack windows when necessary to relieve memory pressure. Simple git programs using wrapper.o as a friendly libc do not need this functionality. So move xmmap to sha1_file.o, where release_pack_memory() is. Signed-off-by: Jonathan Nieder Signed-off-by: Junio C Hamano --- diff --git a/sha1_file.c b/sha1_file.c index 0cd943561..8e299ae85 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -576,6 +576,21 @@ void release_pack_memory(size_t need, int fd) ; /* nothing */ } +void *xmmap(void *start, size_t length, + int prot, int flags, int fd, off_t offset) +{ + void *ret = mmap(start, length, prot, flags, fd, offset); + if (ret == MAP_FAILED) { + if (!length) + return NULL; + release_pack_memory(length, fd); + ret = mmap(start, length, prot, flags, fd, offset); + if (ret == MAP_FAILED) + die_errno("Out of memory? mmap failed"); + } + return ret; +} + void close_pack_windows(struct packed_git *p) { while (p->windows) { diff --git a/wrapper.c b/wrapper.c index fd8ead33e..3195ef32b 100644 --- a/wrapper.c +++ b/wrapper.c @@ -108,21 +108,6 @@ void *xcalloc(size_t nmemb, size_t size) return ret; } -void *xmmap(void *start, size_t length, - int prot, int flags, int fd, off_t offset) -{ - void *ret = mmap(start, length, prot, flags, fd, offset); - if (ret == MAP_FAILED) { - if (!length) - return NULL; - release_pack_memory(length, fd); - ret = mmap(start, length, prot, flags, fd, offset); - if (ret == MAP_FAILED) - die_errno("Out of memory? mmap failed"); - } - return ret; -} - /* * xread() is the same a read(), but it automatically restarts read() * operations with a recoverable error (EAGAIN and EINTR). xread()