From: Ezra Peisach <epeisach@mit.edu>
Date: Sat, 6 Jun 2009 03:55:44 +0000 (+0000)
Subject: kadm5int_acl_parse_restrictions could ref uninitialized variable
X-Git-Tag: krb5-1.8-alpha1~445
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=58989d37a8ce50e04452cdab47b897765a7e7d4e;p=krb5.git

kadm5int_acl_parse_restrictions could ref uninitialized variable

The variable sp is never initialized. If the first argument to the
function is null, the code falls through to freeing sp if valid.
However, sp is never set.

ticket: 6508

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@22402 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/lib/kadm5/srv/server_acl.c b/src/lib/kadm5/srv/server_acl.c
index 88a517a00..76220446d 100644
--- a/src/lib/kadm5/srv/server_acl.c
+++ b/src/lib/kadm5/srv/server_acl.c
@@ -278,7 +278,7 @@ kadm5int_acl_parse_restrictions(s, rpp)
     char		*s;
     restriction_t	**rpp;
 {
-    char		*sp, *tp, *ap;
+    char		*sp = NULL, *tp, *ap;
     static const char	*delims = "\t\n\f\v\r ,";
     krb5_deltat		dt;
     krb5_flags		flag;