From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sun, 30 Aug 2015 15:02:06 +0000 (+0300)
Subject: Re: [PATCH 1/2] emacs: add defsubst notmuch-address--message-insinuated
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=5842a09010f17e20e280e116920c00ef616d536d;p=notmuch-archives.git

Re: [PATCH 1/2] emacs: add defsubst notmuch-address--message-insinuated
---

diff --git a/a5/117b0bf6fb7291072eb66695ecc71a8d8548a1 b/a5/117b0bf6fb7291072eb66695ecc71a8d8548a1
new file mode 100644
index 000000000..4eb2aca9f
--- /dev/null
+++ b/a5/117b0bf6fb7291072eb66695ecc71a8d8548a1
@@ -0,0 +1,74 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 071796DE17EB
+ for <notmuch@notmuchmail.org>; Sun, 30 Aug 2015 08:03:35 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 1.203
+X-Spam-Level: *
+X-Spam-Status: No, score=1.203 tagged_above=-999 required=5 tests=[AWL=-0.193,
+  SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id z_I5zmznAd8Y for <notmuch@notmuchmail.org>;
+ Sun, 30 Aug 2015 08:03:33 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id 007406DE17E1
+ for <notmuch@notmuchmail.org>; Sun, 30 Aug 2015 08:03:32 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id 0713E10005A;
+ Sun, 30 Aug 2015 18:02:07 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 1/2] emacs: add defsubst
+ notmuch-address--message-insinuated
+In-Reply-To: <87y4gtrmdr.fsf@maritornes.cs.unb.ca>
+References: <1440619626-18768-1-git-send-email-tomi.ollila@iki.fi>
+ <87y4gtrmdr.fsf@maritornes.cs.unb.ca>
+User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sun, 30 Aug 2015 18:02:06 +0300
+Message-ID: <m27foc251t.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.18
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 30 Aug 2015 15:03:35 -0000
+
+On Sun, Aug 30 2015, David Bremner <david@tethera.net> wrote:
+
+> Tomi Ollila <tomi.ollila@iki.fi> writes:
+>
+>> +(defsubst notmuch-address--message-insinuated ()
+>> +  (memq notmuch-address-message-alist-member message-completion-alist))
+>> +
+>
+> Is there some advantage to defsubst other than (maybe?) performance?  It
+> just seems like one more construct for people to get up to speed with
+> the codebase.
+
+No advantage. The reason for defsubst may originally be that I did it for
+least execution chance -- and iirc I was reading some (gnus?) code that
+had quite a few defsubsts which infected my coding. Now that I checked
+there is no (other) defsubsts code in notmuch-emacs... so that can be
+just be changed to `defun' to be consistent in that sense.
+
+>
+> d
+
+Tomi