From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Mon, 23 Feb 2015 19:11:32 +0000 (+0200)
Subject: Re: [PATCH 3/3] cli: fix clang build warnings
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=583a39f0b4eb5ad48f0127a0fe2a3726f7a91914;p=notmuch-archives.git

Re: [PATCH 3/3] cli: fix clang build warnings
---

diff --git a/d5/17ad773486ab966f776b0350f06af0f4bb7854 b/d5/17ad773486ab966f776b0350f06af0f4bb7854
new file mode 100644
index 000000000..7cc0111f8
--- /dev/null
+++ b/d5/17ad773486ab966f776b0350f06af0f4bb7854
@@ -0,0 +1,103 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 66108431FDF
+	for <notmuch@notmuchmail.org>; Mon, 23 Feb 2015 11:20:13 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 2.438
+X-Spam-Level: **
+X-Spam-Status: No, score=2.438 tagged_above=-999 required=5
+	tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id nRx30HIWUmD8 for <notmuch@notmuchmail.org>;
+	Mon, 23 Feb 2015 11:20:10 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 271CE431FDE
+	for <notmuch@notmuchmail.org>; Mon, 23 Feb 2015 11:20:10 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id F291410019F;
+	Mon, 23 Feb 2015 21:11:32 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 3/3] cli: fix clang build warnings
+In-Reply-To: <1424710576-30468-3-git-send-email-jani@nikula.org>
+References: <1424710576-30468-1-git-send-email-jani@nikula.org>
+	<1424710576-30468-3-git-send-email-jani@nikula.org>
+User-Agent: Notmuch/0.19+53~gb45d2f9 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Mon, 23 Feb 2015 21:11:32 +0200
+Message-ID: <m2twycmoij.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 23 Feb 2015 19:20:13 -0000
+
+On Mon, Feb 23 2015, Jani Nikula <jani@nikula.org> wrote:
+
+> Fix the following warning produced by clang 3.5.0:
+>
+> notmuch-search.c:730:25: warning: initializing 'void *' with an
+> expression of type 'const notmuch_opt_desc_t (*)[4]' discards
+> qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
+>         { NOTMUCH_OPT_INHERIT, &common_options, NULL, 0, 0 },
+>                                ^~~~~~~~~~~~~~~
+> 1 warning generated.
+>
+> ---
+>
+> I'm not really happy with this one. An alternative would be to drop
+> const from common_options, but I'm not happy with that either. And I'm
+> not happy with the warning. :(
+
+This looks tolerable to be and the whole series good. tests pass.
+
+> ---
+>  notmuch-search.c | 4 ++--
+>  1 file changed, 2 insertions(+), 2 deletions(-)
+>
+> diff --git a/notmuch-search.c b/notmuch-search.c
+> index 14b9f01c5ad1..a591d45b4c39 100644
+> --- a/notmuch-search.c
+> +++ b/notmuch-search.c
+> @@ -671,7 +671,7 @@ notmuch_search_command (notmuch_config_t *config, int argc, char *argv[])
+>  	{ NOTMUCH_OPT_INT, &ctx->offset, "offset", 'O', 0 },
+>  	{ NOTMUCH_OPT_INT, &ctx->limit, "limit", 'L', 0  },
+>  	{ NOTMUCH_OPT_INT, &ctx->dupe, "duplicate", 'D', 0  },
+> -	{ NOTMUCH_OPT_INHERIT, &common_options, NULL, 0, 0 },
+> +	{ NOTMUCH_OPT_INHERIT, (void *) &common_options, NULL, 0, 0 },
+>  	{ 0, 0, 0, 0, 0 }
+>      };
+>  
+> @@ -727,7 +727,7 @@ notmuch_address_command (notmuch_config_t *config, int argc, char *argv[])
+>  	  (notmuch_keyword_t []){ { "true", NOTMUCH_EXCLUDE_TRUE },
+>  				  { "false", NOTMUCH_EXCLUDE_FALSE },
+>  				  { 0, 0 } } },
+> -	{ NOTMUCH_OPT_INHERIT, &common_options, NULL, 0, 0 },
+> +	{ NOTMUCH_OPT_INHERIT, (void *) &common_options, NULL, 0, 0 },
+>  	{ 0, 0, 0, 0, 0 }
+>      };
+>  
+> -- 
+> 2.1.4
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch