From: Mark Walters Date: Wed, 21 May 2014 00:36:41 +0000 (+0100) Subject: Re: [PATCH v1] emacs: `notmuch-search-find-stable-query-region' should never return... X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=57c5be06d42ca7ec923c0bebb27f308965ce6d0e;p=notmuch-archives.git Re: [PATCH v1] emacs: `notmuch-search-find-stable-query-region' should never return an empty query. --- diff --git a/6e/5934e68128a8c0cea13474dadaf2a527fc0922 b/6e/5934e68128a8c0cea13474dadaf2a527fc0922 new file mode 100644 index 000000000..397ead9d3 --- /dev/null +++ b/6e/5934e68128a8c0cea13474dadaf2a527fc0922 @@ -0,0 +1,194 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4944F431FC4 + for ; Tue, 20 May 2014 17:36:56 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.502 +X-Spam-Level: +X-Spam-Status: No, score=0.502 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ZernKZ3IOJKJ for ; + Tue, 20 May 2014 17:36:50 -0700 (PDT) +Received: from mail1.qmul.ac.uk (mail1.qmul.ac.uk [138.37.6.7]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 7B0BB431FBC + for ; Tue, 20 May 2014 17:36:50 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail1.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1WmuWS-0005g7-5G; Wed, 21 May 2014 01:36:46 +0100 +Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1WmuWR-0003Lx-QZ; Wed, 21 May 2014 01:36:44 +0100 +From: Mark Walters +To: David Edmondson , notmuch@notmuchmail.org +Subject: Re: [PATCH v1] emacs: `notmuch-search-find-stable-query-region' + should never return an empty query. +In-Reply-To: +References: <1400515756-31779-1-git-send-email-dme@dme.org> + <87lhtxzb4m.fsf@qmul.ac.uk> + +User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Wed, 21 May 2014 01:36:41 +0100 +Message-ID: <87iop0ynl2.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 87.81.223.162 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 33c8b857d02765d272d395e0f4835329 (of first 20000 bytes) +X-SpamAssassin-Score: -0.1 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.1 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.1 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 21 May 2014 00:36:56 -0000 + + +On Tue, 20 May 2014, David Edmondson wrote: +> On Mon, May 19 2014, Mark Walters wrote: +>> On Mon, 19 May 2014, David Edmondson wrote: +>>> `notmuch-search-find-stable-query-region' is expected to examine the +>>> region between `beg' and `end' to generate a query that can be used to +>>> include all threads in that region. If the region contains no threads, +>>> it should throw an error rather than generating an empty query. +>> +>> Hi +>> +>> This seems a very definite bug (when testing I managed to archive a +>> whole chunk of random messages!) +> +> Do you understand why? I couldn't see a path from this problem to that +> failure mode. + +Ok I now understand some of why it is a bug and it is a pretty gross +mix: emacs does something odd, then notmuch-tag.c then xapian. It only +happens in some cases: + +WARNING the following will archive some random messages: have a dump or +backup or something! + +if you do "a" at the end of the buffer then the emacs code creates the +trivial query: () +Then runs notmuch tag -inbox -- () + +in notmuch-tag.c we are clever and optimise the query (to avoid trying +to remove the tag from messages that don't have it) and this becomes the +query-string + +( () ) and ( tag:inbox ) + +for reasons which aren't clear to me this matches some but not all +of the messages with tag:inbox. This is despite the fact that searching for +( () ) or () by itself yields no results. + +You can test this bit just with notmuch search or count + +notmuch count "(()) and tag:inbox" + +Since this email is rather long I will reply to the rest separately. + +Best wishes + +Mark + + + + + + +> +>> However, I think I would prefer not to signal an error and just do +>> nothing. How about making notmuch-tag check for a nil query (and do +>> nothing it's nil). Then rather than an error n.s.f.s.q.r can just return +>> nil (this still needs to be special cased as otherwise we get "()" as +>> the query. +> +> Looking around for similar issues (like +> `notmuch-show-get-message-properties'), it seems that we would have to +> add checks in a lot of places for functions such as this returning `nil' +> when they cannot find some state or context. +> +> Throwing an error makes it clear to the user that nothing is going to +> happen - it's not just silent failure. +> +> (If it's not clear - that was all "I like that it calls `error' :-). +> +>> Doing this would also fix a bug I found (when seeing what we did +>> elsewhere based on the above) in notmuch-tree: trying to change tags at +>> the end of the buffer gives an error). +>> +>> Best wishes +>> +>> Mark +>> +>> +>> +>>> --- +>>> +>>> Whilst logging calls to 'notmuch' from the UI, I noticed that it would generate +>>> notmuch tag -inbox -- () +>>> if I hit 'a' at the very end of a search buffer. That seems at least +>>> useless and possibly bad, so flag an error in this case instead. +>>> +>>> Oh, the first bit is just cleanup. +>>> +>>> emacs/notmuch.el | 5 ++++- +>>> 1 file changed, 4 insertions(+), 1 deletion(-) +>>> +>>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el +>>> index 8aa0104..74103a6 100644 +>>> --- a/emacs/notmuch.el +>>> +++ b/emacs/notmuch.el +>>> @@ -429,12 +429,15 @@ matched and unmatched messages in the current thread." +>>> +>>> If ONLY-MATCHED is non-nil, include only matched messages. If it +>>> is nil, include both matched and unmatched messages." +>>> - (let ((query-list nil) (all (not only-matched))) +>>> + (let ((all (not only-matched)) +>>> + query-list) +>>> (dolist (queries (notmuch-search-properties-in-region :query beg end)) +>>> (when (first queries) +>>> (push (first queries) query-list)) +>>> (when (and all (second queries)) +>>> (push (second queries) query-list))) +>>> + (unless query-list +>>> + (error "No threads in region.")) +>>> (concat "(" (mapconcat 'identity query-list ") or (") ")"))) +>>> +>>> (defun notmuch-search-find-authors () +>>> -- +>>> 2.0.0.rc0 +>>> +>>> _______________________________________________ +>>> notmuch mailing list +>>> notmuch@notmuchmail.org +>>> http://notmuchmail.org/mailman/listinfo/notmuch