From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Thu, 11 Feb 2016 19:43:01 +0000 (+0100) Subject: Re: [PATCH] notmuch.Database.remove_message should raise exception on failure X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=56ff1f15b9da6e738a2b34696abcb9156962fd85;p=notmuch-archives.git Re: [PATCH] notmuch.Database.remove_message should raise exception on failure --- diff --git a/d5/1ce2a8fcd4a0ef89e18e631865f6214659b643 b/d5/1ce2a8fcd4a0ef89e18e631865f6214659b643 new file mode 100644 index 000000000..1bf142b34 --- /dev/null +++ b/d5/1ce2a8fcd4a0ef89e18e631865f6214659b643 @@ -0,0 +1,65 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id A7C486DE0B4B + for ; Thu, 11 Feb 2016 11:51:08 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.931 +X-Spam-Level: +X-Spam-Status: No, score=-0.931 tagged_above=-999 required=5 + tests=[AWL=-0.941, RCVD_IN_DNSWL_NONE=-0.0001, + T_HEADER_FROM_DIFFERENT_DOMAINS=0.01] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id saZBqut70BuJ for ; + Thu, 11 Feb 2016 11:51:06 -0800 (PST) +X-Greylist: delayed 479 seconds by postgrey-1.35 at arlo; + Thu, 11 Feb 2016 11:51:06 PST +Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) + by arlo.cworth.org (Postfix) with ESMTPS id B0EB16DE0B36 + for ; Thu, 11 Feb 2016 11:51:06 -0800 (PST) +Received: from thinkbox (unknown [85.183.43.52]) + (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) + (No client certificate requested) + by mail.cryptobitch.de (Postfix) with ESMTPSA id B37A599A292; + Thu, 11 Feb 2016 20:43:01 +0100 (CET) +Received: from teythoon by thinkbox with local (Exim 4.84) + (envelope-from ) + id 1aTx8n-00050A-Br; Thu, 11 Feb 2016 20:43:01 +0100 +Content-Type: text/plain; charset="utf-8" +MIME-Version: 1.0 +Content-Transfer-Encoding: quoted-printable +From: Justus Winter <4winter@informatik.uni-hamburg.de> +User-Agent: alot/0.3.8.dev +To: Daniel Kahn Gillmor , + "Notmuch Mail" +References: <1455123226-1929-1-git-send-email-dkg@fifthhorseman.net> +In-Reply-To: <1455123226-1929-1-git-send-email-dkg@fifthhorseman.net> +Message-ID: <20160211194301.10389.63561@thinkbox.jade-hamburg.de> +Subject: Re: [PATCH] notmuch.Database.remove_message should raise exception on + failure +Date: Thu, 11 Feb 2016 20:43:01 +0100 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 11 Feb 2016 19:51:08 -0000 + +Quoting Daniel Kahn Gillmor (2016-02-10 17:53:46) +> The notmuch python bindings document that database.remove_message +> should raise an exception when the message removal fails, but they +> don't actually do it. + +Merged, thanks! + +Justus