From: Tomi Ollila Date: Sat, 4 Oct 2014 08:30:48 +0000 (+0300) Subject: Re: [PATCH 00/11] Add ghost messages and fix thread linking X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=56d6f70f49d6778e3c107aed2e0612616c64e4dc;p=notmuch-archives.git Re: [PATCH 00/11] Add ghost messages and fix thread linking --- diff --git a/f7/8f950046256fcb4cba80eee1588b052320424d b/f7/8f950046256fcb4cba80eee1588b052320424d new file mode 100644 index 000000000..2359baf6d --- /dev/null +++ b/f7/8f950046256fcb4cba80eee1588b052320424d @@ -0,0 +1,89 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 91F0A431FC3 + for ; Sat, 4 Oct 2014 01:31:11 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id VkZ0Vr+ZbOC7 for ; + Sat, 4 Oct 2014 01:31:06 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id AC2F9431FB6 + for ; Sat, 4 Oct 2014 01:31:06 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 2EB6D10008D; + Sat, 4 Oct 2014 11:30:49 +0300 (EEST) +From: Tomi Ollila +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 00/11] Add ghost messages and fix thread linking +In-Reply-To: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu> +References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu> +User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 04 Oct 2014 08:31:11 -0000 + +On Fri, Oct 03 2014, Austin Clements wrote: + +> This series modifies our database representation of messages that have +> been referenced by other messages, but for which we don't have the +> message itself. Currently, we store this information as Xapian +> metadata, but this has several downsides for performance and +> complexity and results in hard-to-fix thread linking bugs. This patch +> series implements "ghost messages", which replace this Xapian metadata +> with Xapian documents that look and act very much like regular message +> documents, but simply have no content. This simplifies and speeds up +> our thread linking algorithm and fixes the currently broken thread +> linking test. +> +> Ghost messages also open up interesting future possibilities, such as +> "pre-seeding" tags for messages that are not yet indexed. This could +> be used to make notmuch insert simpler and more robust, as part of tag +> synchronization, and to improve nmbug's behavior when tags arrive +> before messages. + +The code looks OK to me -- there are IMO some strange things but those +don't change the status quo -- I did look a little past the diffs into +the code to understand something... + +I am now having these patches applied to my 'home' notmuch and haven't yet +seen anything strange there. In this setup I have 27 emails missing that +nmbug expects there to be -- let's see if I can get ghost messages there. + +... and tests pass, ran while writing the above part... + +I'll put these in use next week on one of my 'work' notmuch. There I have +seen a problem that while I am on one thread, +`notmuch-poll-and-refresh-buffer' picks new mail but suddenly this thread +now has changed it's thread id :O -- making the search buffer go blank. +I'll see whether it still happens with these (may be totally unrelated) +and perhaps investigate further... + + +Tomi +