From: David Bremner <david@tethera.net>
Date: Mon, 23 Nov 2015 12:51:03 +0000 (+2000)
Subject: Re: [PATCH] emacs: poll: return useful errors when poll fails.
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=568903e8b795eabe8f0283284447c56bfbc93e44;p=notmuch-archives.git

Re: [PATCH] emacs: poll: return useful errors when poll fails.
---

diff --git a/af/f1a47a2c458b95dfc08526947944d712b45009 b/af/f1a47a2c458b95dfc08526947944d712b45009
new file mode 100644
index 000000000..0b31fd6e0
--- /dev/null
+++ b/af/f1a47a2c458b95dfc08526947944d712b45009
@@ -0,0 +1,69 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id CD2D66DE0943
+ for <notmuch@notmuchmail.org>; Mon, 23 Nov 2015 05:02:48 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.313
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.313 tagged_above=-999 required=5 tests=[AWL=0.238,
+  RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id 0-y9Y66XEHSB for <notmuch@notmuchmail.org>;
+ Mon, 23 Nov 2015 05:02:43 -0800 (PST)
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
+ by arlo.cworth.org (Postfix) with ESMTPS id 7BE076DE0FFA
+ for <notmuch@notmuchmail.org>; Mon, 23 Nov 2015 05:02:43 -0800 (PST)
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
+ (envelope-from <david@tethera.net>)
+ id 1a0qaG-0000UG-2x; Mon, 23 Nov 2015 07:51:04 -0500
+Received: (nullmailer pid 6623 invoked by uid 1000);
+ Mon, 23 Nov 2015 12:51:03 -0000
+From: David Bremner <david@tethera.net>
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org,
+ ketil@malde.org
+Subject: Re: [PATCH] emacs: poll: return useful errors when poll fails.
+In-Reply-To: <1446056919-27822-1-git-send-email-markwalters1009@gmail.com>
+References: <87bnd5qjnd.fsf@wespe.malde.org>
+ <1446056919-27822-1-git-send-email-markwalters1009@gmail.com>
+User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Mon, 23 Nov 2015 08:51:03 -0400
+Message-ID: <87r3jg516w.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 23 Nov 2015 13:02:49 -0000
+
+Mark Walters <markwalters1009@gmail.com> writes:
+
+> Previously poll called from emacs would fail silently. This makes it
+> return a useful error message.
+>
+> In the non-deprecated case of notmuch new and appropriate hooks, it
+> uses notmuch-call-notmuch-process which gives an error and
+> additionally puts the stdout/stderr etc in the *Notmuch errors*
+> buffer.
+>
+> In the deprecated case of a custom poll script it only returns an
+> error message.
+>
+> Commit based on a bug report, and a potential fix, by Ketil Malde.
+
+applied to release and master
+
+d