From: Felipe Contreras Date: Sat, 2 Nov 2013 12:17:17 +0000 (+1800) Subject: Re: [PATCH 0/3] General fixes X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=560fd89a0cfa6dea7ae57e1a56bf17f8bbec4fbe;p=notmuch-archives.git Re: [PATCH 0/3] General fixes --- diff --git a/c9/0bdf784f167071b6a7dfc54ba0472dc8f68b40 b/c9/0bdf784f167071b6a7dfc54ba0472dc8f68b40 new file mode 100644 index 000000000..3074e1455 --- /dev/null +++ b/c9/0bdf784f167071b6a7dfc54ba0472dc8f68b40 @@ -0,0 +1,92 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 87DD9431FC2 + for ; Sat, 2 Nov 2013 05:26:15 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id hIF7DvnRZdJm for ; + Sat, 2 Nov 2013 05:26:10 -0700 (PDT) +Received: from mail-oa0-f48.google.com (mail-oa0-f48.google.com + [209.85.219.48]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 11303431FAF + for ; Sat, 2 Nov 2013 05:26:10 -0700 (PDT) +Received: by mail-oa0-f48.google.com with SMTP id m17so5525081oag.7 + for ; Sat, 02 Nov 2013 05:26:08 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=date:from:to:message-id:in-reply-to:references:subject:mime-version + :content-type:content-transfer-encoding; + bh=DVDAovIfM0m+cp0ml1dQcg5njtbuIJW5dX6HQZ9aN2A=; + b=pQrojb+a4zdD8jnjXYKsv4ivt552avqOWBXIPDTmghEOZGineCGAR9UnVc5RbMi3BI + TS6HZErR6mr9F3P9/kMSIkGEohLBz8GA8TrvJPIUm1ZOxbYpoM/TWpc6e3u2ULLCn6Rc + pHXFv74oiZXU8rZSnMRFjDDSanAl4LoT2MG/YYhFNGN2rRn+xAM/xhkehg8IudEmVNM/ + H0588qXg0UVTr3jGsURStatRgogwN9DW+PH+2gwgbx20hK5e2WGYr2FrjD5mOcrjNhMD + 7QOE3VnMBM8kf67nn6ALLnRxH++pcGGZYc4N4ntzV9jXbIrEP1MXS+M82cYS39joTQgg + +NzQ== +X-Received: by 10.60.157.2 with SMTP id wi2mr6189095oeb.35.1383395168567; + Sat, 02 Nov 2013 05:26:08 -0700 (PDT) +Received: from localhost (187-162-140-241.static.axtel.net. [187.162.140.241]) + by mx.google.com with ESMTPSA id + nw5sm19547576obc.9.2013.11.02.05.26.07 for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sat, 02 Nov 2013 05:26:07 -0700 (PDT) +Date: Sat, 02 Nov 2013 06:17:17 -0600 +From: Felipe Contreras +To: David Bremner , + Felipe Contreras , notmuch@notmuchmail.org +Message-ID: <5274ed4d5126a_46fcefbe747f@nysa.notmuch> +In-Reply-To: <87txgpv16s.fsf@zancas.localnet> +References: <1380558523-6913-1-git-send-email-felipe.contreras@gmail.com> + <87txgpv16s.fsf@zancas.localnet> +Subject: Re: [PATCH 0/3] General fixes +Mime-Version: 1.0 +Content-Type: text/plain; + charset=utf-8 +Content-Transfer-Encoding: 7bit +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 02 Nov 2013 12:26:15 -0000 + +David Bremner wrote: +> Felipe Contreras writes: +> +> > Felipe Contreras (3): +> > query: bind queries to database objects +> > ruby: allow build with RUNPATH +> > ruby: bind database close()/destroy() properly +> +> I agree with the discussion on IRC that the change in the first patch +> makes sense. + +Shall I push it to the master branch then? + +> It would be nice to have a bit more explanation in the commit message of +> the second message; at least to point out that (iiuc) this is not a +> really a ruby specific thing, just a standard ld.so feature. + +I don't really care that much about patch #2, but #3 should probably be +applied. + +The important is #1 though. + +-- +Felipe Contreras