From: David Bremner <david@tethera.net>
Date: Mon, 6 Oct 2014 06:03:06 +0000 (+0200)
Subject: Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=55e00dc8da653e07a9e74cf9312c660c547a5c13;p=notmuch-archives.git

Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature
---

diff --git a/9a/0118fcc919fed61bbc49c76d0c007010d5140a b/9a/0118fcc919fed61bbc49c76d0c007010d5140a
new file mode 100644
index 000000000..50a77b168
--- /dev/null
+++ b/9a/0118fcc919fed61bbc49c76d0c007010d5140a
@@ -0,0 +1,75 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id EEFCD431FB6
+	for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 23:03:26 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id HTXtr2Vkf-DE for <notmuch@notmuchmail.org>;
+	Sun,  5 Oct 2014 23:03:22 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 423A7431FAE
+	for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 23:03:22 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1Xb1O9-0004CM-D3; Mon, 06 Oct 2014 03:03:17 -0300
+Received: (nullmailer pid 17966 invoked by uid 1000); Mon, 06 Oct 2014
+	06:03:06 -0000
+From: David Bremner <david@tethera.net>
+To: Austin Clements <aclements@csail.mit.edu>
+Subject: Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature
+In-Reply-To: <20141005232956.GD7970@csail.mit.edu>
+References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>
+	<1412345958-8278-9-git-send-email-aclements@csail.mit.edu>
+	<87d2a6q4hf.fsf@maritornes.cs.unb.ca>
+	<20141005232956.GD7970@csail.mit.edu>
+User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Mon, 06 Oct 2014 08:03:06 +0200
+Message-ID: <874mvhpwf9.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+Cc: notmuch@notmuchmail.org
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 06 Oct 2014 06:03:27 -0000
+
+Austin Clements <aclements@csail.mit.edu> writes:
+
+> Quoth David Bremner on Oct 05 at 10:56 am:
+>> Austin Clements <aclements@csail.mit.edu> writes:
+>> > +    if (new_features & NOTMUCH_FEATURE_GHOSTS) {
+>> > +	t_end = db->metadata_keys_end ("thread_id_");
+>> > +	for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t)
+>> > +	    ++total;
+>> > +    }
+>> 
+>> It would be nice to have the comment below, or something like it, for
+>> the loop above.
+>
+>   /* The ghost message upgrade converts all thread_id_*
+>    * metadata values into ghost message documents. */
+> sound good?
+
+Fine.
+
+d