From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Fri, 25 Sep 2015 19:17:05 +0000 (+0300)
Subject: Re: [PATCH] test suite: don't consider skipped individual tests as failing
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=55356740f5094e3498dbc6c623076147d5dc51c6;p=notmuch-archives.git

Re: [PATCH] test suite: don't consider skipped individual tests as failing
---

diff --git a/c9/4858a6b7fb95d411ad90fc8750558af3e5246b b/c9/4858a6b7fb95d411ad90fc8750558af3e5246b
new file mode 100644
index 000000000..a69c22f93
--- /dev/null
+++ b/c9/4858a6b7fb95d411ad90fc8750558af3e5246b
@@ -0,0 +1,71 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id C90E26DE0924
+ for <notmuch@notmuchmail.org>; Fri, 25 Sep 2015 12:17:06 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 1.157
+X-Spam-Level: *
+X-Spam-Status: No, score=1.157 tagged_above=-999 required=5 tests=[AWL=-0.239,
+  SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id mWBCdIL_EVrE for <notmuch@notmuchmail.org>;
+ Fri, 25 Sep 2015 12:17:04 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id 49A056DE02D2
+ for <notmuch@notmuchmail.org>; Fri, 25 Sep 2015 12:17:04 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id AA5CA10008D;
+ Fri, 25 Sep 2015 22:17:05 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] test suite: don't consider skipped individual tests as
+ failing
+In-Reply-To: <87twqi1y9r.fsf@zancas.localnet>
+References: <1443093210-6511-1-git-send-email-david@tethera.net>
+ <m27fnf4mqn.fsf@guru.guru-group.fi> <87twqi1y9r.fsf@zancas.localnet>
+User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Fri, 25 Sep 2015 22:17:05 +0300
+Message-ID: <m2pp16mhqm.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.18
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 25 Sep 2015 19:17:07 -0000
+
+On Fri, Sep 25 2015, David Bremner <david@tethera.net> wrote:
+
+> Tomi Ollila <tomi.ollila@iki.fi> writes:
+>
+>>
+>> Looks OK, but I think there should be (some good) comment here informing
+>> any potential viewer that we're not checking $skipped...
+>>
+>
+> I put some vaguely threatening comment in test/README, and a brief
+> comment in the file. I've merged the commit, but feel free to send
+> suggestions / patches for further doc changes. I more or less made up a
+> hypothetical future policy on the spot...
+
+ack. earlier today I though of make target test-strict -- let's see
+whethere I come up something with that...
+
+>
+> d