From: David Edmondson Date: Mon, 1 Dec 2014 06:41:23 +0000 (+0000) Subject: Re: [Vagrant Cascadian] Bug#759646: notmuch-emacs: switching mode= to invalid value... X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=54f43931e323637d8755b2a9ccd4425355e07777;p=notmuch-archives.git Re: [Vagrant Cascadian] Bug#759646: notmuch-emacs: switching mode= to invalid value sends unencrypted mail --- diff --git a/57/2b9f408f5964a84507e11293fb68648cb16b06 b/57/2b9f408f5964a84507e11293fb68648cb16b06 new file mode 100644 index 000000000..419614efb --- /dev/null +++ b/57/2b9f408f5964a84507e11293fb68648cb16b06 @@ -0,0 +1,110 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 25097431FC7 + for ; Sun, 30 Nov 2014 22:41:36 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.699 +X-Spam-Level: +X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7, UNPARSEABLE_RELAY=0.001] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id OipnLRwDWPYn for ; + Sun, 30 Nov 2014 22:41:27 -0800 (PST) +Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com + [209.85.212.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 06CD2431FBC + for ; Sun, 30 Nov 2014 22:41:26 -0800 (PST) +Received: by mail-wi0-f173.google.com with SMTP id r20so23453864wiv.12 + for ; Sun, 30 Nov 2014 22:41:25 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:in-reply-to:references:user-agent + :from:date:message-id:mime-version:content-type; + bh=yBRC1PjyX4PtRlWklH+FBHSRL5RQ3wc9JRC6flBLdPs=; + b=FwGYHUg2sau/GxAe/h1UBSdZQP6wCw0QQhIscFvgaV4lcnZjGQWkOXlcOIG08Sg8pI + IF3RWNIObsnEXUMmOpPcEIiRxjizgl2DyhuvvJTAaN5l18Q9ivGURgAJvC9Qsv7onPg1 + uYwfrbWAT+VDUKzU8t6VVIKTTgB+YH/6mQHm8qmFGUwnO1Wh2oj55FA1qOUbsQZOZuJR + HY6fM0sGflVk4VBwNOdBu5D71hzTxwJY7XYdp4EmMkihmKKLmeyJK1CzUzU1F/blML35 + 9gf6KpAqsFqfLkz9xguNVCg7uXrmBL51w5qlOiXY/nVWUWT4zKt9uAJUQ/l6aFG4UuLw + gXZg== +X-Gm-Message-State: + ALoCoQmvHk+qmbyzcMLPxH9Joc/F569yJUo7bnZEieb0WZwcAJpiKxfmzHL7jJdOoxakm1tBPOGl +X-Received: by 10.194.234.40 with SMTP id ub8mr93502423wjc.100.1417416085851; + Sun, 30 Nov 2014 22:41:25 -0800 (PST) +Received: from disaster-area.hh.sledj.net + ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) + by mx.google.com with ESMTPSA id s9sm27080954wiz.12.2014.11.30.22.41.24 + for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sun, 30 Nov 2014 22:41:25 -0800 (PST) +Received: from localhost (30000@localhost [local]); + by localhost (OpenSMTPD) with ESMTPA id ffd2a11a; + Mon, 1 Dec 2014 06:41:23 +0000 (UTC) +To: David Bremner , notmuch@notmuchmail.org, + 759646@bugs.debian.org +Subject: Re: [Vagrant Cascadian] Bug#759646: notmuch-emacs: + switching mode= to invalid value sends unencrypted mail +In-Reply-To: <87egsldds6.fsf@maritornes.cs.unb.ca> +References: <87lhq7npcw.fsf@maritornes.cs.unb.ca> <87k35q2zso.fsf@nikula.org> + <54055C53.40604@fifthhorseman.net> + + + <87egsldds6.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +From: David Edmondson +Date: Mon, 01 Dec 2014 06:41:23 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 01 Dec 2014 06:41:36 -0000 + +On Sat, Nov 29 2014, David Bremner wrote: +> David Edmondson writes: +> +>> On Tue, Sep 02 2014, Tomi Ollila wrote: +>>> On Tue, Sep 02 2014, Daniel Kahn Gillmor wrote: +>>> +>>>> On 08/30/2014 03:37 AM, Jani Nikula wrote: +>>>>> I'm inclined to think this is a bug in message-mode. +>>>> +>>>> I agree it's a bug in message-mode, not in notmuch itself. +>>> +>>> I think it might be here: +>>> +>>> http://bzr.savannah.gnu.org/lh/emacs/emacs-24/annotate/head:/lisp/gnus/mml.el#L258 +>>> +>>> (it takes time to load, please wait...) +>>> +>>> If cond does not match, then don't fail... +>> +>> This looks to have been fixed in emacs at the end of September 2014. +> +> Right, this fix was released in emacs 24.4 +> +> I'm a little torn what to do here. On the one hand the upstream change +> fixes the bug as reported. On the other hand, if something corrupts the +> #secure tag (e.g., by deleting a letter), then the message is still sent +> un-uncrypted. + +I'm unclear on what you mean. Is it that "upgrade to 24.4" is not a good +enough answer, because we are still leaving pre-24.4 people out in the +cold?