From: W. Trevor King <wking@drexel.edu>
Date: Sun, 17 Apr 2011 01:01:53 +0000 (-0400)
Subject: Raise exceptions if bug or comment value files are missing.
X-Git-Tag: 1.1.0~208
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=54801289d1c29a57571c3630a438f811370d74cd;p=be.git

Raise exceptions if bug or comment value files are missing.

This happens most often when a previous crash leaves an empty
directory `abc` in .be/.../bugs/abc/ or
.be/.../bugs/.../comments/abc/.  The new exception ensures the error
message is "Bug/Comment X missing value file" which tells you where to
look for the repository corruption not "summary is None" which told
you nothing.
---

diff --git a/libbe/bug.py b/libbe/bug.py
index bbe6980..71682d5 100644
--- a/libbe/bug.py
+++ b/libbe/bug.py
@@ -641,8 +641,7 @@ class Bug (settings_object.SavedSettingsObject):
 
     def load_settings(self, settings_mapfile=None):
         if settings_mapfile == None:
-            settings_mapfile = \
-                self.storage.get(self.id.storage('values'), default='\n')
+            settings_mapfile = self.storage.get(self.id.storage('values'))
         try:
             settings = mapfile.parse(settings_mapfile)
         except mapfile.InvalidMapfileContents, e:
diff --git a/libbe/comment.py b/libbe/comment.py
index 8ffb3cd..081ba59 100644
--- a/libbe/comment.py
+++ b/libbe/comment.py
@@ -611,8 +611,7 @@ class Comment (Tree, settings_object.SavedSettingsObject):
         if self.uuid == INVALID_UUID:
             return
         if settings_mapfile == None:
-            settings_mapfile = \
-                self.storage.get(self.id.storage("values"), default="\n")
+            settings_mapfile = self.storage.get(self.id.storage('values'))
         try:
             settings = mapfile.parse(settings_mapfile)
         except mapfile.InvalidMapfileContents, e: