From: Joey Hess <joey@kitenet.net>
Date: Sat, 8 May 2010 06:15:04 +0000 (-0400)
Subject: avoid setting cookie for promptless buttons
X-Git-Tag: 3.20100515~56
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=541298e66892300f9d98d089c59b7ad837e49016;p=ikiwiki.git

avoid setting cookie for promptless buttons

I think it is clearer to not have such a button appear pre-selected
when entering the signin page, because that may suggest to the user
they don't need to click on it, and yet they do.
---

diff --git a/underlays/openid-selector/ikiwiki/openid/openid-jquery.js b/underlays/openid-selector/ikiwiki/openid/openid-jquery.js
index 4dfb7420b..59a59c084 100644
--- a/underlays/openid-selector/ikiwiki/openid/openid-jquery.js
+++ b/underlays/openid-selector/ikiwiki/openid/openid-jquery.js
@@ -150,15 +150,16 @@ var openid = {
   		}
 		
 		this.highlight(box_id);
-		this.setCookie(box_id);
 		
 		this.provider_id = box_id;
 		this.provider_url = provider['url'];
 		
 		// prompt user for input?
 		if (provider['label']) {
+			this.setCookie(box_id);
 			this.useInputBox(provider);
 		} else {
+			this.setCookie('');
 			$('#openid_input_area').empty();
 			if (! onload) {
 				$('#openid_form').submit();