From: David Bremner <david@tethera.net>
Date: Sun, 17 Jul 2016 10:38:10 +0000 (+2100)
Subject: Re: [PATCH] add has: query prefix to search for specific properties
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=541138aab577f6dca7b90a82777625be362e3c06;p=notmuch-archives.git

Re: [PATCH] add has: query prefix to search for specific properties
---

diff --git a/ed/5394975916606ee573f319067868873945e88f b/ed/5394975916606ee573f319067868873945e88f
new file mode 100644
index 000000000..3effd8e6b
--- /dev/null
+++ b/ed/5394975916606ee573f319067868873945e88f
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id B02226DE0140
+ for <notmuch@notmuchmail.org>; Sun, 17 Jul 2016 03:38:25 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.011
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.011 tagged_above=-999 required=5 tests=[AWL=0.000,
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id fqSpxGyx_Pih for <notmuch@notmuchmail.org>;
+ Sun, 17 Jul 2016 03:38:17 -0700 (PDT)
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
+ by arlo.cworth.org (Postfix) with ESMTPS id 3B15F6DE0130
+ for <notmuch@notmuchmail.org>; Sun, 17 Jul 2016 03:38:17 -0700 (PDT)
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
+ (envelope-from <david@tethera.net>)
+ id 1bOjT1-0005aS-5m; Sun, 17 Jul 2016 06:38:35 -0400
+Received: (nullmailer pid 609 invoked by uid 1000);
+ Sun, 17 Jul 2016 10:38:10 -0000
+From: David Bremner <david@tethera.net>
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
+ Notmuch Mail <notmuch@notmuchmail.org>
+Subject: Re: [PATCH] add has: query prefix to search for specific properties
+In-Reply-To: <87ziphxfl2.fsf@zancas.localnet>
+References: <1465779955-5539-9-git-send-email-david@tethera.net>
+ <1467969336-7605-1-git-send-email-dkg@fifthhorseman.net>
+ <87ziphxfl2.fsf@zancas.localnet>
+User-Agent: Notmuch/0.22+28~gb9bf3f4 (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Sun, 17 Jul 2016 07:38:10 -0300
+Message-ID: <87wpkky2gd.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 17 Jul 2016 10:38:25 -0000
+
+David Bremner <david@tethera.net> writes:
+
+> Do we want to have the same prefix listed in BOOLEAN_PREFIX_INTERNAL and
+> BOOLEAN_PREFIX_EXTERNAL? this seems quite fragile. If we don't though,
+> we have to use the same prefix name for queries as in the code (which is
+> already sprinkled with _find_prefix ("property") ).
+
+Thinking about it a bit more, there's really no problem here. The
+invariant to maintain is the names are unique across all 3 tables used
+by _find_prefix, not the necessarily the prefixes. Indeed there's
+already the example of "is" and "tag".
+
+d