From: Kim Minh Kaplan Date: Thu, 3 Apr 2014 06:03:36 +0000 (+0000) Subject: Re: [Patch v5 3/6] util: add gz_readline X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=53ef8cb05e39efcb196c6ed14940c2e8d3085a71;p=notmuch-archives.git Re: [Patch v5 3/6] util: add gz_readline --- diff --git a/da/aacd3e53c3c3c6c384b7d385b45fd1cb725751 b/da/aacd3e53c3c3c6c384b7d385b45fd1cb725751 new file mode 100644 index 000000000..65414d65d --- /dev/null +++ b/da/aacd3e53c3c3c6c384b7d385b45fd1cb725751 @@ -0,0 +1,86 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 30F3B431FBF + for ; Wed, 2 Apr 2014 23:04:30 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 49Ffp6P+aZQv for ; + Wed, 2 Apr 2014 23:04:26 -0700 (PDT) +Received: from mx4.nic.fr (mx4.nic.fr [192.134.4.12]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E428F431FAE + for ; Wed, 2 Apr 2014 23:04:25 -0700 (PDT) +Received: from mx4.nic.fr (localhost [127.0.0.1]) + by mx4.nic.fr (Postfix) with SMTP id 243142806C5; + Thu, 3 Apr 2014 08:04:23 +0200 (CEST) +Received: from relay2.nic.fr (relay2.nic.fr [192.134.4.163]) + by mx4.nic.fr (Postfix) with ESMTP id 1F3452806BD; + Thu, 3 Apr 2014 08:04:23 +0200 (CEST) +Received: from kaki.tech.prive.nic.fr (kaki.tech.prive.sqy.nic.fr + [10.10.86.114]) by relay2.nic.fr (Postfix) with ESMTP id 0EC2DB3803F; + Thu, 3 Apr 2014 08:03:37 +0200 (CEST) +Received: by kaki.tech.prive.nic.fr (Postfix, from userid 1000) + id E99433F8244; Thu, 3 Apr 2014 06:03:36 +0000 (UTC) +From: Kim Minh Kaplan +To: Tomi Ollila +Subject: Re: [Patch v5 3/6] util: add gz_readline +References: <1396401381-18128-1-git-send-email-david@tethera.net> + <1396401381-18128-4-git-send-email-david@tethera.net> + <20140402032644.GB25677@mit.edu> +X-Face: C!5Mk_!qB]35}VpD|H>GN/@fk%~7:*/x8&~\]|r|)/zV?rJ){uX4Nh`a$L/z__Kx4Gt!mDU3kZlj)F2]Ds$?l'; + SO9]v^|[i2nY`pZ+mu+HT%5ITkuP#e]@8F4@Hc.=]oN1+d\M@Rl>-$C?h$yntf-JVx)3L2}VzG.!bQEy]~I_3fup`HtZ^t/Iz.|Vh$~o`^g\ +Date: Thu, 03 Apr 2014 06:03:36 +0000 +In-Reply-To: (Tomi Ollila's message of + "Wed, 02 Apr 2014 19:43:07 +0300") +Message-ID: <87y4zn2blz.fsf@kaki.tech.prive.nic.fr> +User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-Mailman-Approved-At: Thu, 03 Apr 2014 13:15:01 -0700 +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 03 Apr 2014 06:04:30 -0000 + +Tomi Ollila writes: + +> On Wed, Apr 02 2014, Austin Clements wrote: +> +>> Quoth David Bremner on Apr 01 at 10:16 pm: +>> +>>> + if (len =3D=3D 0 || buf =3D=3D NULL) { +>>> + /* same as getdelim from gnulib */ +>>> + len =3D 120; +>> +>> This is presumably because glibc's malloc has an 8 byte header. Fun +>> fact: talloc has a 104 byte header (on 64-bit and including the malloc +>> header). +> +> hmm, what should we choose here? 152 ? Some bikeshedding on IRC ? + +When your done with this bikeshed, do not forget the other one=C2=A0: + +>>> + len *=3D 2; + +--=20 +Kim Minh.