From: Michal Sojka Date: Wed, 6 Jan 2016 21:27:46 +0000 (+0100) Subject: Re: [PATCH 1/3] emacs: Fix mail composition under Emacs 23 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=538744b102c3d8ae2e610ab67b5fdbef00f34264;p=notmuch-archives.git Re: [PATCH 1/3] emacs: Fix mail composition under Emacs 23 --- diff --git a/f3/717a2566653f8663456b26830602980335f07d b/f3/717a2566653f8663456b26830602980335f07d new file mode 100644 index 000000000..a1adc82e6 --- /dev/null +++ b/f3/717a2566653f8663456b26830602980335f07d @@ -0,0 +1,84 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 54E2E6DE100C + for ; Wed, 6 Jan 2016 13:27:56 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -1.55 +X-Spam-Level: +X-Spam-Status: No, score=-1.55 tagged_above=-999 required=5 tests=[AWL=0.760, + RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, + RCVD_IN_MSPIKE_WL=-0.01, T_HEADER_FROM_DIFFERENT_DOMAINS=0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id rwTO07qA6HCB for ; + Wed, 6 Jan 2016 13:27:53 -0800 (PST) +Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) + by arlo.cworth.org (Postfix) with ESMTP id 280046DE1003 + for ; Wed, 6 Jan 2016 13:27:52 -0800 (PST) +Received: from localhost (unknown [192.168.200.7]) + by max.feld.cvut.cz (Postfix) with ESMTP id E27D619F49CC; + Wed, 6 Jan 2016 22:27:49 +0100 (CET) +X-Virus-Scanned: IMAP STYX AMAVIS +Received: from max.feld.cvut.cz ([192.168.200.1]) + by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new, port 10044) + with ESMTP id S05iBpI4b3bB; Wed, 6 Jan 2016 22:27:48 +0100 (CET) +Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) + by max.feld.cvut.cz (Postfix) with ESMTP id 403C719F477C; + Wed, 6 Jan 2016 22:27:47 +0100 (CET) +Received: from wsh by steelpick.2x.cz with local (Exim 4.86) + (envelope-from ) + id 1aGvcQ-000527-4B; Wed, 06 Jan 2016 22:27:46 +0100 +From: Michal Sojka +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/3] emacs: Fix mail composition under Emacs 23 +In-Reply-To: <8760z8ah7e.fsf@zancas.localnet> +References: <1451753265-26713-1-git-send-email-sojkam1@fel.cvut.cz> + <1451753265-26713-2-git-send-email-sojkam1@fel.cvut.cz> + <8760z8ah7e.fsf@zancas.localnet> +User-Agent: Notmuch/0.21+30~g55c056a (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Wed, 06 Jan 2016 22:27:46 +0100 +Message-ID: <87ziwiv1nx.fsf@steelpick.2x.cz> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 06 Jan 2016 21:27:56 -0000 + +On Tue, Jan 05 2016, David Bremner wrote: +> Michal Sojka writes: +> +>> + (when return-action (nconc args '(return-action))) +>> + (apply 'message-setup-1 +>> + ;; The following sexp is copied from `message-mail' +> +>> + (nconc +>> + `((To . ,(or to "")) (Subject . ,(or subject ""))) +> +> I missed this the first time, but I a bit worried about this used of +> nconc. It seems to fall under "A common pitfall is to use a quoted +> constant list as a non-last argument to =E2=80=98nconc=E2=80=99" (from t= +he elisp +> manual). In any case it's not really performance critical code (I +> guess?) so maybe we could just use append? + +Yes, this make sense. As the nconc is already in master, I'll not +combine the fix for this with 1/3, but I'm sending a separate patch that +applies after 3/3. + +-Michal