From: Jani Nikula Date: Sun, 5 May 2013 12:45:35 +0000 (+0300) Subject: Re: [PATCH 0/2] Enhancements to notmuch-hello search history X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=52d8edeca3a74f0046d9b51097c1293784e43f9b;p=notmuch-archives.git Re: [PATCH 0/2] Enhancements to notmuch-hello search history --- diff --git a/24/5bf2a4d725213bd83c58991f83e707cca34516 b/24/5bf2a4d725213bd83c58991f83e707cca34516 new file mode 100644 index 000000000..6a0e4e9f6 --- /dev/null +++ b/24/5bf2a4d725213bd83c58991f83e707cca34516 @@ -0,0 +1,89 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 336D5431FAF + for ; Sun, 5 May 2013 05:45:49 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id a0Ul-8idye3n for ; + Sun, 5 May 2013 05:45:44 -0700 (PDT) +Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com + [209.85.217.170]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 6DFD8431FAE + for ; Sun, 5 May 2013 05:45:44 -0700 (PDT) +Received: by mail-lb0-f170.google.com with SMTP id t11so2707636lbd.15 + for ; Sun, 05 May 2013 05:45:42 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=x-received:from:to:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type:x-gm-message-state; + bh=3sfUfXwj/Cas7j6AHrHKmem6Q7hZ8momnks11TP5kRM=; + b=RzG8gccF60uNVYN8plC8y2cCdAx6L/g3cAoJ2FbWjjtx+PbI49ZSNkZAbmkWNIK7sW + KSnFwAl/jMD+/yIxTJR+I8LpbEkSCHOiz5+pvG6UpJsr6oYfE+FXCr0RlVXHLDevOG7s + HyMHXzig/xXY6kwaCU+cKw3+ggi1CttKUeCe89rEF50df3SH+ApLVRGnk+TniNz834As + C5E7qVAHSlH0nel7dgpkmu4AB+hvrNXbXmw3wQ1kg3GMvrIVluF29FOcoujtXpsFxt3P + ElgqUBDitYxZEg3OWkq54YzYNDCPdOCCOxq4QnVLQwR9POWo5rd5FeYUylRdW1XVJq04 + AyWg== +X-Received: by 10.112.144.36 with SMTP id sj4mr6735405lbb.1.1367757941361; + Sun, 05 May 2013 05:45:41 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw2-58c376-211.dhcp.inet.fi. + [88.195.118.211]) + by mx.google.com with ESMTPSA id z10sm5364689lbv.14.2013.05.05.05.45.39 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sun, 05 May 2013 05:45:40 -0700 (PDT) +From: Jani Nikula +To: Tomi Ollila , + Servilio Afre Puentes , + notmuch +Subject: Re: [PATCH 0/2] Enhancements to notmuch-hello search history +In-Reply-To: +References: <87y5bwkml2.fsf@goose.CSU.McMaster.CA> <874nejrupr.fsf@nikula.org> + <87ppx6lo6g.fsf@goose.CSU.McMaster.CA> + +User-Agent: Notmuch/0.15.2+87~gc69f540 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 05 May 2013 15:45:35 +0300 +Message-ID: <87a9o9fvdc.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-Gm-Message-State: + ALoCoQlQNzmZpx+GzR6PZ9U1LhFYO2PvsN0ltE4W+mikj15lxR3cKNfu9eEX735C86ms+pE1ToSj +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 05 May 2013 12:45:49 -0000 + +On Sun, 05 May 2013, Tomi Ollila wrote: +> I agree with Jani that y-or-n-p would suffice for clearing all +> recent searches (but yes-or-no-p is not so bad as I originally thought +> as C-g can be used to stop processing (typoing 'no' is too easy ;/). +> +> If we could use "undo" feature to restore last clear/del then I'd agree +> 100% with Mark (i.e. no y-or-n-p for [del]). +> +> In any case fix at least the style issue Mark mentioned -- any of the +> yes/no queries will eventually be fine with me (as I don't know without +> experience what would be the best (for me) after all). + +Servilio, please switch to y-or-n-p in patch 1 and fix the style issue +in patch 2, and I think we're happy on the average. :) + +Jani.