From: Tomi Ollila Date: Fri, 7 Aug 2015 04:11:19 +0000 (+0300) Subject: Re: [PATCH 2/2] emacs: make modifications to message Fcc vars buffer-local X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=529140f6c44a66741bd554bb45f69c5b62b732da;p=notmuch-archives.git Re: [PATCH 2/2] emacs: make modifications to message Fcc vars buffer-local --- diff --git a/0e/e844866c4644edc0629ac23116a42d52d23b4a b/0e/e844866c4644edc0629ac23116a42d52d23b4a new file mode 100644 index 000000000..a64f83619 --- /dev/null +++ b/0e/e844866c4644edc0629ac23116a42d52d23b4a @@ -0,0 +1,84 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 9604B6DE1104 + for ; Thu, 6 Aug 2015 21:11:37 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 1.249 +X-Spam-Level: * +X-Spam-Status: No, score=1.249 tagged_above=-999 required=5 tests=[AWL=-0.147, + SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id deBR8q9eDCDu for ; + Thu, 6 Aug 2015 21:11:35 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id C01D56DE09ED + for ; Thu, 6 Aug 2015 21:11:33 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id CCBEC100046; + Fri, 7 Aug 2015 07:11:19 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , + Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/2] emacs: make modifications to message Fcc vars + buffer-local +In-Reply-To: <874mkcw318.fsf@maritornes.cs.unb.ca> +References: <87fv4093sl.fsf@maritornes.cs.unb.ca> + <1438718659-11522-1-git-send-email-david@tethera.net> + <1438718659-11522-2-git-send-email-david@tethera.net> + <874mkcw318.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.20.2+54~g0bf3ee6 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 07 Aug 2015 04:11:37 -0000 + +On Thu, Aug 06 2015, David Bremner wrote: + +> Tomi Ollila writes: +> +>> +>> One thing come to my mind: would it be possible to use buffer-local +>> variable message-fcc-handler-function in notmuch-message-mode buffers so +>> that such wrapper functions defined below would not be needed. i.e. +>> +>> (make-local-variable 'message-fcc-handler-function) +>> (setq message-fcc-handler-function #'notmuch-fcc-handler) +>> +> +> This was my first approach, and I actually filed +> +> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21174 +> +> about why it doesn't work. +> +> Great minds think alike / Fools seldom differ, as they say ;) + +Uh ;/ You could add some note about buffer-local variables not +applicable in this context for future archeologists to understand ;) +-- either in commit message or in comment.. + +> +> d + +Tomi