From: Mark Walters Date: Sun, 15 Sep 2013 14:35:03 +0000 (+0100) Subject: [PATCH 0/3] Use global keymap for pick entry. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=52682f8df88cd069a56a046c8cd89b548ee950c2;p=notmuch-archives.git [PATCH 0/3] Use global keymap for pick entry. --- diff --git a/57/654ac61b823c3d22ca8709a5b12083d06c6ad1 b/57/654ac61b823c3d22ca8709a5b12083d06c6ad1 new file mode 100644 index 000000000..7731b4d7b --- /dev/null +++ b/57/654ac61b823c3d22ca8709a5b12083d06c6ad1 @@ -0,0 +1,86 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 42516431FC2 + for ; Sun, 15 Sep 2013 07:35:18 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.201 +X-Spam-Level: +X-Spam-Status: No, score=0.201 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id nAHmP8+TORsG for ; + Sun, 15 Sep 2013 07:35:12 -0700 (PDT) +Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com + [209.85.212.178]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 87FFA431FAE + for ; Sun, 15 Sep 2013 07:35:12 -0700 (PDT) +Received: by mail-wi0-f178.google.com with SMTP id hn9so2487442wib.11 + for ; Sun, 15 Sep 2013 07:35:11 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id; + bh=Q8acsoaCgXSDnFDS+UETqBluheAKhzqhof8AKGYP1pY=; + b=IIXPy3CqUg+E67o53yRPGfGHkYFSmC8vcR4H+PWlR7sP0MMRb0DQsvw+ZIjHkRBYNc + qK939TznU9dWC2y+9VQQTo70bbrRZ2dT5osETSk25a16VXGO1mCqtPXNDnhkne0iv+kI + cgvovw1uVw4d5cwGt166jWbyAOCdgaYUiEyWDJrbKEiC9ZwlkzEd7jHprHtS07PHiUPG + qzYC/cKGD/S9iAw86D4Ywkc9zWieXBY8x7YyRYzn6VC8l10uLS6qg1R734/Cf1nk1xey + D4YKVuZxs3jxVVAdkTjt6nIpRkfgc/czgqpo4OOJPuNSs5zfZtXNwekz4cieaudYXLyT + KowQ== +X-Received: by 10.194.110.138 with SMTP id ia10mr18923719wjb.3.1379255711241; + Sun, 15 Sep 2013 07:35:11 -0700 (PDT) +Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) + by mx.google.com with ESMTPSA id fb9sm16887146wid.7.1969.12.31.16.00.00 + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sun, 15 Sep 2013 07:35:10 -0700 (PDT) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH 0/3] Use global keymap for pick entry. +Date: Sun, 15 Sep 2013 15:35:03 +0100 +Message-Id: <1379255706-2418-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 15 Sep 2013 14:35:18 -0000 + +This uses the recently added global keymap for pick entry. Adding this +showed a couple of historical anomalies: first that we don't need to +quote the keymap in define-key, and secondly that the +notmuch-pick-from-hello function is no longer needed. + +Thus we remove the superfluous quotes and we remove the unneeded +function. + +All tests pass and all key bindings still seem to work. + +Best wishes + +Mark + + +Mark Walters (3): + contrib: pick: remove some superfluous quotes + contrib: pick: use the new notmuch-common-keymap for pick entry + contrib: pick: remove unused notmuch-pick-from-hello + + contrib/notmuch-pick/notmuch-pick.el | 21 ++++----------------- + 1 files changed, 4 insertions(+), 17 deletions(-) + +-- +1.7.9.1 +