From: David Bremner Date: Mon, 13 Jun 2016 13:02:45 +0000 (+2100) Subject: Re: [PATCH 2/8] lib: private string map (associative array) API X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=51b7f79146ddbb96c60412604345a3b8d5c2450a;p=notmuch-archives.git Re: [PATCH 2/8] lib: private string map (associative array) API --- diff --git a/21/c51a3b05c33cf093eb2e1588839749fd12d77a b/21/c51a3b05c33cf093eb2e1588839749fd12d77a new file mode 100644 index 000000000..9db52939e --- /dev/null +++ b/21/c51a3b05c33cf093eb2e1588839749fd12d77a @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 2B5B86DE0159 + for ; Mon, 13 Jun 2016 06:03:05 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.011 +X-Spam-Level: +X-Spam-Status: No, score=-0.011 tagged_above=-999 required=5 + tests=[AWL=-0.000, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id UndLpeHuNAiA for ; + Mon, 13 Jun 2016 06:02:56 -0700 (PDT) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 498436DE0127 + for ; Mon, 13 Jun 2016 06:02:56 -0700 (PDT) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1bCRVi-0004Lc-4h; Mon, 13 Jun 2016 09:02:34 -0400 +Received: (nullmailer pid 24715 invoked by uid 1000); + Mon, 13 Jun 2016 13:02:45 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/8] lib: private string map (associative array) API +In-Reply-To: +References: <1465779955-5539-1-git-send-email-david@tethera.net> + <1465779955-5539-3-git-send-email-david@tethera.net> + +User-Agent: Notmuch/0.22+28~gb9bf3f4 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Mon, 13 Jun 2016 10:02:45 -0300 +Message-ID: <871t41utqi.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 13 Jun 2016 13:03:05 -0000 + +Tomi Ollila writes: + +> On Mon, Jun 13 2016, David Bremner wrote: +> +>> The choice of array implementation is deliberate, for future iterator support +>> --- +>> lib/Makefile.local | 1 + +>> lib/notmuch-private.h | 11 ++++ +>> lib/string-map.c | 153 ++++++++++++++++++++++++++++++++++++++++++++++++++ +>> 3 files changed, 165 insertions(+) +>> create mode 100644 lib/string-map.c +>> +>> diff --git a/lib/Makefile.local b/lib/Makefile.local +>> index beb9635..9280880 100644 +>> --- a/lib/Makefile.local +>> +++ b/lib/Makefile.local +>> @@ -40,6 +40,7 @@ libnotmuch_c_srcs = \ +>> $(dir)/messages.c \ +>> $(dir)/sha1.c \ +>> $(dir)/built-with.c \ +>> + $(dir)/string-map.c \ +>> $(dir)/tags.c +> +> I suggest everyone to install editor which supports showing tabs & spaces +> e.g. in different color and also visualizes trailing whitespace & trailing +> empty lines... +> + +Heh. If only such a thing existed. What about a pre-commit hook? +The default (that I have) uses git diff --index --check --cached, but +that seems not to be enough. + +d