From: David Bremner <david@tethera.net>
Date: Mon, 23 Sep 2013 10:39:04 +0000 (+2100)
Subject: Re: [PATCH] contrib: pick: tidy up pick-format-field
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=51687b43918806004c3af5108a4bacd74943723c;p=notmuch-archives.git

Re: [PATCH] contrib: pick: tidy up pick-format-field
---

diff --git a/c9/ee67fa9e6052741b7bb8091e9e4bbbab7c71ae b/c9/ee67fa9e6052741b7bb8091e9e4bbbab7c71ae
new file mode 100644
index 000000000..3b0007468
--- /dev/null
+++ b/c9/ee67fa9e6052741b7bb8091e9e4bbbab7c71ae
@@ -0,0 +1,60 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 54257431FBC
+	for <notmuch@notmuchmail.org>; Mon, 23 Sep 2013 03:40:17 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 1.274
+X-Spam-Level: *
+X-Spam-Status: No, score=1.274 tagged_above=-999 required=5
+	tests=[RDNS_NONE=1.274] autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id csWcCBOnNtCD for <notmuch@notmuchmail.org>;
+	Mon, 23 Sep 2013 03:40:11 -0700 (PDT)
+Received: from yantan.tethera.net (unknown [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 3276F431FB6
+	for <notmuch@notmuchmail.org>; Mon, 23 Sep 2013 03:40:11 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1VO3YT-0004b0-Qr; Mon, 23 Sep 2013 07:39:49 -0300
+Received: (nullmailer pid 21057 invoked by uid 1000); Mon, 23 Sep 2013
+	10:39:04 -0000
+From: David Bremner <david@tethera.net>
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] contrib: pick: tidy up pick-format-field
+In-Reply-To: <1379234477-14089-1-git-send-email-markwalters1009@gmail.com>
+References: <1379234477-14089-1-git-send-email-markwalters1009@gmail.com>
+User-Agent: Notmuch/0.16+71~gfd656d7 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Mon, 23 Sep 2013 07:39:04 -0300
+Message-ID: <87ioxrzut3.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 23 Sep 2013 10:40:17 -0000
+
+Mark Walters <markwalters1009@gmail.com> writes:
+
+> Previously this function used a temporary variable to store the return
+> value but we can just use the return value of the cond statement
+> directly.
+
+pushed.
+
+d