From: Austin Clements Date: Wed, 9 Oct 2013 14:08:50 +0000 (+2000) Subject: Re: [PATCH 02/11] cli: Separate current and deprecated format version X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=4fff54caae9009a9cc8186aea2f0ec4ea93801c3;p=notmuch-archives.git Re: [PATCH 02/11] cli: Separate current and deprecated format version --- diff --git a/fd/180af59a284a80cacf2c71951dc3bca3db58ef b/fd/180af59a284a80cacf2c71951dc3bca3db58ef new file mode 100644 index 000000000..c55e0dd4e --- /dev/null +++ b/fd/180af59a284a80cacf2c71951dc3bca3db58ef @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 24E2B431FAF + for ; Wed, 9 Oct 2013 07:09:02 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id pPb7refKTZVU for ; + Wed, 9 Oct 2013 07:08:56 -0700 (PDT) +Received: from dmz-mailsec-scanner-8.mit.edu (dmz-mailsec-scanner-8.mit.edu + [18.7.68.37]) + by olra.theworths.org (Postfix) with ESMTP id CB001431FAE + for ; Wed, 9 Oct 2013 07:08:55 -0700 (PDT) +X-AuditID: 12074425-b7f1c8e0000009c7-0f-525563778bde +Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) + by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP + id 8B.9A.02503.77365525; Wed, 9 Oct 2013 10:08:55 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id r99E8rCk002739; + Wed, 9 Oct 2013 10:08:54 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r99E8orr018982 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Wed, 9 Oct 2013 10:08:52 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1VTuRW-0004yN-JH; Wed, 09 Oct 2013 10:08:50 -0400 +Date: Wed, 9 Oct 2013 10:08:50 -0400 +From: Austin Clements +To: Mark Walters +Subject: Re: [PATCH 02/11] cli: Separate current and deprecated format version +Message-ID: <20131009140850.GN21611@mit.edu> +References: <1381185201-25197-1-git-send-email-amdragon@mit.edu> + <1381185201-25197-3-git-send-email-amdragon@mit.edu> + <87li24qmvj.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <87li24qmvj.fsf@qmul.ac.uk> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IRYrdT1y1PDg0y6HvCbrF6Lo/F9ZszmR2Y + PHbOusvu8WzVLeYApigum5TUnMyy1CJ9uwSujKmvLjMV3OeqODTtB2sD41aOLkZODgkBE4n/ + B16zQthiEhfurWcDsYUE9jFKXJ6X1cXIBWRvYJRY83M7E0TiFJPE9dmVEIkljBLvj6xgBkmw + CKhITHt3gxHEZhPQkNi2fzmYLSKgI3H70AJ2EJtZQFri2+9msEHCAn4Sh168BevlBap5+L2B + GWLoVEaJW18bGCESghInZz5hgWjWkrjx7yVQMwfYoOX/OEBMTqBd+1osQCpEgU6YcnIb2wRG + oVlImmchaZ6F0LyAkXkVo2xKbpVubmJmTnFqsm5xcmJeXmqRroVebmaJXmpK6SZGcEi7qO5g + nHBI6RCjAAejEg9vB29IkBBrYllxZe4hRkkOJiVR3u0xoUFCfEn5KZUZicUZ8UWlOanFhxgl + OJiVRHiNo4FyvCmJlVWpRfkwKWkOFiVx3lsc9kFCAumJJanZqakFqUUwWRkODiUJ3tWJQI2C + RanpqRVpmTklCGkmDk6Q4TxAw6+D1PAWFyTmFmemQ+RPMSpKifMygCQEQBIZpXlwvbCU84pR + HOgVYd6bIFU8wHQF1/0KaDAT0ODt30NABpckIqSkGhhZusU0z7s9NcrqW7hwwiTPZyEbhO9P + Uj60/Ubzub9TpO76PW7dfSLDzlsvx708yDr4xQ87N98lq9bNL+2e4OHzslbTPs/KTfCv88oA + +U9VBurrFjba7npTxV418ZnpQtfbJ/6+VlR+/4pxVU14zaIzBUcmqjOJPZz46bpG7eXSjU8f + zfvQu81PiaU4I9FQi7moOBEAXQkHaRQDAAA= +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 09 Oct 2013 14:09:02 -0000 + +Quoth Mark Walters on Oct 08 at 7:48 am: +> On Mon, 07 Oct 2013, Austin Clements wrote: +> > Previously, the CLI would print a deprecation warning if a client +> > requested any format version other than the current one. However, if +> > we add fields that are backwards-compatible, but want clients to be +> > able to depend on, we need to bump the version, but that doesn't make +> > the older version deprecated. +> > +> > Hence, separate out the "minimum active" version and only print a +> > warning for requests below this version number. +> > --- +> > notmuch-client.h | 5 +++++ +> > notmuch.c | 2 +- +> > 2 files changed, 6 insertions(+), 1 deletion(-) +> > +> > diff --git a/notmuch-client.h b/notmuch-client.h +> > index afb0ddf..8d986f4 100644 +> > --- a/notmuch-client.h +> > +++ b/notmuch-client.h +> > @@ -142,6 +142,11 @@ chomp_newline (char *str) +> > /* The minimum supported structured output format version. Requests +> > * for format versions below this will return an error. */ +> > #define NOTMUCH_FORMAT_MIN 1 +> > +/* The minimum non-deprecated structured output format version. +> > + * Requests for format versions below this will print a stern warning. +> > + * Must be >= NOTMUCH_FORMAT_MIN and < NOTMUCH_FORMAT_CUR. +> > + */ +> +> Should this be <= NOTMUCH_FORMAT_CUR ? + +Yes. + +> Best wishes +> +> Mark