From: David Bremner Date: Sun, 24 Aug 2014 20:39:23 +0000 (+1700) Subject: Re: [PATCH v3] nmbug: Translate to Python X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=4fd8ac6a43d0b264133177bd77b8551e25f3d4a7;p=notmuch-archives.git Re: [PATCH v3] nmbug: Translate to Python --- diff --git a/ea/46d752ab2711b3d08bff881bb9681357a6e5b2 b/ea/46d752ab2711b3d08bff881bb9681357a6e5b2 new file mode 100644 index 000000000..cb4eade32 --- /dev/null +++ b/ea/46d752ab2711b3d08bff881bb9681357a6e5b2 @@ -0,0 +1,87 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A40D0431FAF + for ; Sun, 24 Aug 2014 13:39:33 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Tq1Ofejdz-Yf for ; + Sun, 24 Aug 2014 13:39:28 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 38229431FAE + for ; Sun, 24 Aug 2014 13:39:28 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1XLeZT-0006ct-3F; Sun, 24 Aug 2014 17:39:27 -0300 +Received: (nullmailer pid 16215 invoked by uid 1000); Sun, 24 Aug 2014 + 20:39:23 -0000 +From: David Bremner +To: "W. Trevor King" +Subject: Re: [PATCH v3] nmbug: Translate to Python +In-Reply-To: <20140806232131.GH31313@odin.tremily.us> +References: + <84447a0ed48412e1587761d560d18cb5affd4f66.1405897133.git.wking@tremily.us> + <878un36bd5.fsf@maritornes.cs.unb.ca> + <20140806232131.GH31313@odin.tremily.us> +User-Agent: Notmuch/0.18.1+72~g028c560 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 24 Aug 2014 13:39:23 -0700 +Message-ID: <871ts5ei6c.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 24 Aug 2014 20:39:33 -0000 + +"W. Trevor King" writes: +> +>> > +__version__ =3D '0.2' +>>=20 +>> Do we need/want a version distinct from that of notmuch? +> +> nmbug is very loosely bound to the notmuch core. To me it feels like +> a separate project that happens to share the same version control +> repository. I'm happy to synchronize versions, but then we have to +> remember to bump the nmbug version for each notmuch release. + +Unless/until we split nmbug from notmuch I'd rather keep the versions +the same to avoid confusion. I guess the "right way" (TM) would be +share the hackery used in doc/conf.py to parse the version file and use +it from python. + +>> as a non-native speaker of python, I find this a bit hard to read. +>> How about adding some parens to make the multiple return more clear, +>> so +>>=20 +>> (status, tree, stderr) =3D _git( +> +> That's legal, but I rarely see the parenthesized version in the wild. +> For examples showing the unparenthesized version, see [2,3]. +> Parentheses are optional for Python tuples [4], so you'd only want +> them if =E2=80=98=3D=E2=80=99 had a higher precedence than =E2=80=98,=E2= +=80=99. That's my argument for +> the unparenthesized version, but feel free to overrule me ;). + +I'd rather go with readability (which I admit is subjective) then try to +minimize parens. We're lisp programmers, after all ;).