From: David Bremner Date: Wed, 17 Jun 2015 06:23:31 +0000 (+0200) Subject: Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=4fb561bd09e5d32d95a93ff0af12902f1a19ecb1;p=notmuch-archives.git Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable --- diff --git a/34/5964ae4c1e3d3f0042aa55aef7c6281d3814a6 b/34/5964ae4c1e3d3f0042aa55aef7c6281d3814a6 new file mode 100644 index 000000000..0f7d3a22b --- /dev/null +++ b/34/5964ae4c1e3d3f0042aa55aef7c6281d3814a6 @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id A219D6DE0243 + for ; Tue, 16 Jun 2015 23:25:48 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.185 +X-Spam-Level: +X-Spam-Status: No, score=0.185 tagged_above=-999 required=5 tests=[AWL=0.185] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ehHTDp91GSk4 for ; + Tue, 16 Jun 2015 23:25:46 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) + by arlo.cworth.org (Postfix) with ESMTPS id 88F1D6DE01F5 + for ; Tue, 16 Jun 2015 23:25:46 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.80) (envelope-from ) + id 1Z56lJ-0003uv-Va; Wed, 17 Jun 2015 06:23:49 +0000 +Received: (nullmailer pid 12660 invoked by uid 1000); Wed, 17 Jun 2015 + 06:23:31 -0000 +From: David Bremner +To: Jinwoo Lee , Tomi Ollila , + notmuch@notmuchmail.org +Subject: Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable +In-Reply-To: +References: <1433142542-2307-3-git-send-email-david@tethera.net> + <1434261524-14139-1-git-send-email-david@tethera.net> + + <87r3peye4q.fsf@maritornes.cs.unb.ca> + + <87oaki3zrh.fsf@maritornes.cs.unb.ca> + + + + + +User-Agent: Notmuch/0.20.1+21~g4e79903 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Wed, 17 Jun 2015 08:23:31 +0200 +Message-ID: <87vbem26qk.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 17 Jun 2015 06:25:48 -0000 + +Jinwoo Lee writes: +> FAIL PATH is set to build directory +> --- T000-basic.11.expected 2015-06-16 23:40:30.000000000 +0000 +> +++ T000-basic.11.output 2015-06-16 23:40:30.000000000 +0000 +> @@ -1 +1 @@ +> -/Users/jinwoo/Box Sync/personal/project/notmuch +> + +> usage: dirname path + +This failure is because of spaces in your pathname. It might be simpler +to run in a different directory rather than fix all the problems this +causes in the test suite. + +> FAIL notmuch is compiled with debugging symbols +> --- T000-basic.12.expected 2015-06-16 23:40:30.000000000 +0000 +> +++ T000-basic.12.output 2015-06-16 23:40:30.000000000 +0000 +> @@ -1 +1 @@ +> -1 +> +0 +> ./T000-basic.sh: line 95: readelf: command not found + +This test, as it says, is testing if notmuch was compiled with debugging +symbols. Rather than yet another special case for mac, I'd be curious +if there is a portable test for this (perhaps using nm?). In any case, +this one test failing should not be fatal. + +> ./test-lib.sh: line 1062: $test_results_path: ambiguous redirect +> ./test-lib.sh: line 1063: $test_results_path: ambiguous redirect +> ./test-lib.sh: line 1064: $test_results_path: ambiguous redirect +> ./test-lib.sh: line 1065: $test_results_path: ambiguous redirect +> ./test-lib.sh: line 1066: $test_results_path: ambiguous redirect +> ./test-lib.sh: line 1067: $test_results_path: ambiguous redirect + +At a guess, this again has to do with spaces in the pathname. Maybe this +is fixable with more quoting, but it's really independent of mac vs +gnu/linux. In this instance it looks like quoting "test_results_path" +would help.