From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sun, 11 Oct 2015 16:45:56 +0000 (+0300)
Subject: Re: V2 of directory delete patches
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=4f1217e0f87d6605aec46b1ea68cb86bffe987f1;p=notmuch-archives.git

Re: V2 of directory delete patches
---

diff --git a/6b/cbb0134d237add97d966278bfe2d0b1fad3093 b/6b/cbb0134d237add97d966278bfe2d0b1fad3093
new file mode 100644
index 000000000..18d38a061
--- /dev/null
+++ b/6b/cbb0134d237add97d966278bfe2d0b1fad3093
@@ -0,0 +1,68 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 2E9666DE111A
+ for <notmuch@notmuchmail.org>; Sun, 11 Oct 2015 09:46:05 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 1.139
+X-Spam-Level: *
+X-Spam-Status: No, score=1.139 tagged_above=-999 required=5 tests=[AWL=-0.257,
+  SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id khraIwCbhQ30 for <notmuch@notmuchmail.org>;
+ Sun, 11 Oct 2015 09:46:03 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id D6C396DE100F
+ for <notmuch@notmuchmail.org>; Sun, 11 Oct 2015 09:46:02 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id 8D45310005B;
+ Sun, 11 Oct 2015 19:45:56 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,
+ notmuch@notmuchmail.org
+Subject: Re: V2 of directory delete patches
+In-Reply-To: <1444480039-8530-1-git-send-email-david@tethera.net>
+References:
+ <591f5298ac3f2c79f727cac8bad1251830b28a3c.1443213654.git.jani@nikula.org>
+ <1444480039-8530-1-git-send-email-david@tethera.net>
+User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sun, 11 Oct 2015 19:45:56 +0300
+Message-ID: <m2a8rp9wvv.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.18
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 11 Oct 2015 16:46:05 -0000
+
+On Sat, Oct 10 2015, David Bremner <david@tethera.net> wrote:
+
+> Changes since id:cover.1443213654.git.jani@nikula.org
+>
+>   - tidy commit messages
+>   - update docs in lib/notmuch.h
+>   - make an executive decision not to push _remove_directory into lib
+>   for now; it can always be a new api layer later.
+>   - unmark fixed tests
+>   - wrap xapian calls in try/catch
+
+
+Looks good to me. tests pass.
+
+Tomi