From: Jeffrey Altman Date: Thu, 13 May 2004 03:16:24 +0000 (+0000) Subject: * send_tgs.c: krb5_send_tgs() was broken in the case of a KRB_ERROR X-Git-Tag: krb5-1.4-beta1~416 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=4e4aa2861591cea00587a611d0c414c44f55be75;p=krb5.git * send_tgs.c: krb5_send_tgs() was broken in the case of a KRB_ERROR message. The krb5_response message_type field was never set resulting in stack garbage being used instead. This would break code which used transitive cross-realm to obtain service tickets. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16331 dc483132-0cff-0310-8789-dd5450dbe970 --- diff --git a/src/lib/krb5/krb/ChangeLog b/src/lib/krb5/krb/ChangeLog index 9305d9014..736eeba80 100644 --- a/src/lib/krb5/krb/ChangeLog +++ b/src/lib/krb5/krb/ChangeLog @@ -1,3 +1,11 @@ +2004-05-12 Jeffrey Altman + + * send_tgs.c: krb5_send_tgs() was broken in the case of a KRB_ERROR + message. The krb5_response message_type field was never set + resulting in stack garbage being used instead. This would + break code which used transitive cross-realm to obtain service + tickets. + 2004-04-24 Ken Raeburn * conv_creds.c (krb524_init_ets, krb524_convert_creds_kdc): Add diff --git a/src/lib/krb5/krb/send_tgs.c b/src/lib/krb5/krb/send_tgs.c index 3b6b24288..a5ffe1d4b 100644 --- a/src/lib/krb5/krb/send_tgs.c +++ b/src/lib/krb5/krb/send_tgs.c @@ -279,6 +279,7 @@ send_again: } krb5_free_error(context, err_reply); } + rep->message_type = KRB5_ERROR; } else if (krb5_is_tgs_rep(&rep->response)) rep->message_type = KRB5_TGS_REP; else /* XXX: assume it's an error */