From: David Bremner <david@tethera.net>
Date: Tue, 14 May 2013 00:43:24 +0000 (+2100)
Subject: Re: [PATCH 2/2] lib/database.cc: change how the parent of a message is calculated
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=4d14d10b908e13866bea087af54409d0a5773b73;p=notmuch-archives.git

Re: [PATCH 2/2] lib/database.cc: change how the parent of a message is calculated
---

diff --git a/28/233cc0de20ee4cfd59165e2f40f43770edb1b5 b/28/233cc0de20ee4cfd59165e2f40f43770edb1b5
new file mode 100644
index 000000000..371c34f5b
--- /dev/null
+++ b/28/233cc0de20ee4cfd59165e2f40f43770edb1b5
@@ -0,0 +1,70 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 76CC5431FC4
+	for <notmuch@notmuchmail.org>; Mon, 13 May 2013 17:43:28 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: -2.3
+X-Spam-Level: 
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
+	tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id MNrsA70ps4PY for <notmuch@notmuchmail.org>;
+	Mon, 13 May 2013 17:43:28 -0700 (PDT)
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
+	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 1AEC3431FC2
+	for <notmuch@notmuchmail.org>; Mon, 13 May 2013 17:43:28 -0700 (PDT)
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
+	by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r4E0hRBn014058;
+	Mon, 13 May 2013 21:43:27 -0300
+Received: from remotemail by tesseract.cs.unb.ca with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1Uc3Kw-0003gH-OP; Mon, 13 May 2013 21:43:26 -0300
+Received: (nullmailer pid 10110 invoked by uid 1000);
+	Tue, 14 May 2013 00:43:24 -0000
+From: David Bremner <david@tethera.net>
+To: Aaron Ecay <aaronecay@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 2/2] lib/database.cc: change how the parent of a message
+	is calculated
+In-Reply-To: <1362540709-28765-2-git-send-email-aaronecay@gmail.com>
+References: <87ppzfzxuk.fsf@zancas.localnet>
+	<1362540709-28765-1-git-send-email-aaronecay@gmail.com>
+	<1362540709-28765-2-git-send-email-aaronecay@gmail.com>
+User-Agent: Notmuch/0.15.2+69~g360c3c8 (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-pc-linux-gnu)
+Date: Mon, 13 May 2013 21:43:24 -0300
+Message-ID: <87d2sugzmb.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 14 May 2013 00:43:28 -0000
+
+Aaron Ecay <aaronecay@gmail.com> writes:
+
+> Presently, the code which finds the parent of a message as it is being
+> added to the database assumes that the first Message-ID-like substring
+> of the In-Reply-To header is the parent Message ID.  Some mail
+> clients, however, put stuff other than the Message-ID of the parent in
+> the In-Reply-To header, such as the email address of the sender of the
+> parent.  This can fool notmuch.
+>
+
+Pushed both, with a certain amount of hacking on the test patch.
+
+d