From: Tomi Ollila Date: Wed, 21 Aug 2013 11:26:57 +0000 (+0300) Subject: Re: [PATCH 4/4] timegm: add portable implementation (Solaris support) X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=4ce5e675736d68966bc2b89ba4e76ad61a6cf110;p=notmuch-archives.git Re: [PATCH 4/4] timegm: add portable implementation (Solaris support) --- diff --git a/1f/805990e6fd3f9a4d0e9c526395ba24fcf942ee b/1f/805990e6fd3f9a4d0e9c526395ba24fcf942ee new file mode 100644 index 000000000..9e08b21d4 --- /dev/null +++ b/1f/805990e6fd3f9a4d0e9c526395ba24fcf942ee @@ -0,0 +1,77 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4B0D8431FC7 + for ; Wed, 21 Aug 2013 04:27:17 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id TyOu3X0N7B4j for ; + Wed, 21 Aug 2013 04:27:07 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 9545B431FC2 + for ; Wed, 21 Aug 2013 04:27:07 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id B9ABF100086; + Wed, 21 Aug 2013 14:26:57 +0300 (EEST) +From: Tomi Ollila +To: Vladimir.Marek@oracle.com, notmuch@notmuchmail.org +Subject: Re: [PATCH 4/4] timegm: add portable implementation (Solaris support) +In-Reply-To: <1377083394-29755-1-git-send-email-Vladimir.Marek@oracle.com> +References: + <1377083394-29755-1-git-send-email-Vladimir.Marek@oracle.com> +User-Agent: Notmuch/0.16+3~g340c058 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +Cc: Vladimir Marek +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 21 Aug 2013 11:27:17 -0000 + +On Wed, Aug 21 2013, Vladimir.Marek@oracle.com wrote: + +> From: Blake Jones +> +> The timegm(3) function is a non-standard extension to libc which is +> available in GNU libc and on some BSDs. Although SunOS had this +> function in its libc, Solaris (unfortunately) removed it. This patch +> implements a very simple version of timegm() which is good enough for +> parse-time-string.c. +> +> Signed-off-by: Vladimir Marek +> --- + +Thanks, LGTM. + +> compat/Makefile.local | 4 +++ +> compat/compat.h | 5 +++ +> compat/have_timegm.c | 7 +++++ +> compat/timegm.c | 56 +++++++++++++++++++++++++++++++++ +> configure | 11 +++++++ +> parse-time-string/parse-time-string.c | 1 + +> 6 files changed, 84 insertions(+) +> create mode 100644 compat/have_timegm.c +> create mode 100644 compat/timegm.c +>