From: Jameson Graef Rollins Date: Thu, 23 Jun 2011 01:14:12 +0000 (+1700) Subject: [PATCH] emacs: Show all multipart/alternative parts by default. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=4b982766fc7ccba9c8b04e72eb9a14f6aa6c0b24;hp=7b71657b44bcb02da8e08eac05ac731a5d877143;p=notmuch-archives.git [PATCH] emacs: Show all multipart/alternative parts by default. --- diff --git a/d3/5787d5a75f2afc515b91ae66df6967511353b3 b/d3/5787d5a75f2afc515b91ae66df6967511353b3 new file mode 100644 index 000000000..eef81dc5b --- /dev/null +++ b/d3/5787d5a75f2afc515b91ae66df6967511353b3 @@ -0,0 +1,88 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 289C5431FD0 + for ; Wed, 22 Jun 2011 18:14:23 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.921 +X-Spam-Level: +X-Spam-Status: No, score=-1.921 tagged_above=-999 required=5 + tests=[NO_DNS_FOR_FROM=0.379, RCVD_IN_DNSWL_MED=-2.3] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id RI7iddnPZMHp for ; + Wed, 22 Jun 2011 18:14:22 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id B2BC3431FB6 + for ; Wed, 22 Jun 2011 18:14:22 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id BBC3666E0211; + Wed, 22 Jun 2011 18:14:20 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from servo.finestructure.net (gwave-224.ligo.caltech.edu + [131.215.114.224]) (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id 9349F66E013C; + Wed, 22 Jun 2011 18:14:13 -0700 (PDT) +Received: by servo.finestructure.net (Postfix, from userid 1000) + id BF85326B; Wed, 22 Jun 2011 18:14:14 -0700 (PDT) +From: Jameson Graef Rollins +To: Notmuch Mail +Subject: [PATCH] emacs: Show all multipart/alternative parts by default. +Date: Wed, 22 Jun 2011 18:14:12 -0700 +Message-Id: <1308791652-17372-2-git-send-email-jrollins@finestructure.net> +X-Mailer: git-send-email 1.7.5.4 +In-Reply-To: <1308791652-17372-1-git-send-email-jrollins@finestructure.net> +References: <1308791652-17372-1-git-send-email-jrollins@finestructure.net> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 23 Jun 2011 01:14:23 -0000 + +This is patch is a temporary work-around for a slight regression that +popped up in the part handling reorganization. Currently, text/plain +parts are always preferred, if present, over other non-text/plain +parts in multipart/alternative. However, this means that if there is +a blank text/plain part, no content will be displayed. + +One way to get around this is to set the +"notmuch-show-all-multipart/alternative-parts" customization variable +to True ('t'), which will cause all parts to always be displayed. + +Since we want to move forward with the next release, we're going to +set this variable true by default, to make sure that no content is +unretrievably hidden from the user. Once we come up with a better +solution for easy display of hidden parts we can set this back to a +default value of 'nil'. +--- + emacs/notmuch-show.el | 2 +- + 1 files changed, 1 insertions(+), 1 deletions(-) + +diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +index 0d9b52a..af1d44b 100644 +--- a/emacs/notmuch-show.el ++++ b/emacs/notmuch-show.el +@@ -96,7 +96,7 @@ same as that of the previous message." + notmuch-wash-excerpt-citations)) + + ;; Mostly useful for debugging. +-(defcustom notmuch-show-all-multipart/alternative-parts nil ++(defcustom notmuch-show-all-multipart/alternative-parts t + "Should all parts of multipart/alternative parts be shown?" + :group 'notmuch + :type 'boolean) +-- +1.7.5.4 +