From: Austin Clements Date: Tue, 22 Oct 2013 19:50:50 +0000 (+2000) Subject: [PATCH 1/8] emacs: Fix misuse of `notmuch-tag' X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=4a71090daebf7922d245c7b111899a5968050b6c;p=notmuch-archives.git [PATCH 1/8] emacs: Fix misuse of `notmuch-tag' --- diff --git a/37/668ba8efaae022b20891c2b8405dc56256e452 b/37/668ba8efaae022b20891c2b8405dc56256e452 new file mode 100644 index 000000000..cc56762d2 --- /dev/null +++ b/37/668ba8efaae022b20891c2b8405dc56256e452 @@ -0,0 +1,97 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C7DD3431E82 + for ; Tue, 22 Oct 2013 12:51:12 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 4jafm6ItMFmZ for ; + Tue, 22 Oct 2013 12:51:06 -0700 (PDT) +Received: from dmz-mailsec-scanner-1.mit.edu (dmz-mailsec-scanner-1.mit.edu + [18.9.25.12]) + by olra.theworths.org (Postfix) with ESMTP id 75E5C431FBC + for ; Tue, 22 Oct 2013 12:51:06 -0700 (PDT) +X-AuditID: 1209190c-b7fd38e0000009aa-d7-5266d7292f7e +Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) + by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP + id 7D.16.02474.927D6625; Tue, 22 Oct 2013 15:51:05 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id r9MJp3OC020279; + Tue, 22 Oct 2013 15:51:04 -0400 +Received: from drake.dyndns.org (31-33-57.wireless.csail.mit.edu + [128.31.33.57]) (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r9MJp0Xd005188 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Tue, 22 Oct 2013 15:51:03 -0400 +Received: from amthrax by drake.dyndns.org with local (Exim 4.77) + (envelope-from ) + id 1VYhym-0006yd-Hz; Tue, 22 Oct 2013 15:51:00 -0400 +From: Austin Clements +To: notmuch@notmuchmail.org +Subject: [PATCH 1/8] emacs: Fix misuse of `notmuch-tag' +Date: Tue, 22 Oct 2013 15:50:50 -0400 +Message-Id: <1382471457-26056-2-git-send-email-amdragon@mit.edu> +X-Mailer: git-send-email 1.8.4.rc3 +In-Reply-To: <1382471457-26056-1-git-send-email-amdragon@mit.edu> +References: <1382471457-26056-1-git-send-email-amdragon@mit.edu> +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsUixG6nrqt5PS3IYNMyE4vrN2cyOzB6PFt1 + izmAMYrLJiU1J7MstUjfLoErY37jBPaCqRwVx/Y/YWpgfMTWxcjJISFgIvF08QUmCFtM4sK9 + 9UBxLg4hgX2MEn2vO9khnI2MEt8af7KAVAkJHGOSeL9eHMKeyyix4GkAiM0moCGxbf9yRhBb + REBaYufd2axdjBwczAJqEn+6VEDCwgLmEh2vL7KDhFkEVCXOXbIBCfMKOEhMOvmUFeIGJYmF + p7aB2ZwCjhLT9/1jAykXAqo5dYdjAiP/AkaGVYyyKblVurmJmTnFqcm6xcmJeXmpRbqGermZ + JXqpKaWbGEHhwinJs4PxzUGlQ4wCHIxKPLwPWtKChFgTy4orcw8xSnIwKYnyRlwFCvEl5adU + ZiQWZ8QXleakFh9ilOBgVhLhbfYFyvGmJFZWpRblw6SkOViUxHlvctgHCQmkJ5akZqemFqQW + wWRlODiUJHgfgQwVLEpNT61Iy8wpQUgzcXCCDOcBGn4MpIa3uCAxtzgzHSJ/ilFRSpz3BkhC + ACSRUZoH1wuL51eM4kCvCEO08wBTAVz3K6DBTECDpywBG1ySiJCSamDk+t5+7FVv3yzPAgmt + 9xUqxz8qXFjDksd3yXrtiTLGTWaG69ndp0c1LWVNe/Tv7joFffWUjbW/WeJ+3vT/rHdN/0Tr + nXvSb/buvCDrcyuxXz5+S9u2Mzd/LbLi2a8ncnpWb0DLjyt71FXY19YlzlyVUbmxyHbSvvQP + mt0W0y3yldZVV6avCatWYinOSDTUYi4qTgQAQlC87cICAAA= +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 22 Oct 2013 19:51:13 -0000 + +The calling convention for `notmuch-tag' changed in commit 97aa3c06 to +take a list of tag changes instead of a &rest argument, but the call +from `notmuch-search-tag-all' still passed a &rest argument. This +happened to work for interactive calls because tag-changes would be +nil, so the `apply' call would pass only the query string to +`notmuch-tag' and simply omit the &optional tag-changes argument. +--- + emacs/notmuch.el | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/emacs/notmuch.el b/emacs/notmuch.el +index c47c6b5..e0511c8 100644 +--- a/emacs/notmuch.el ++++ b/emacs/notmuch.el +@@ -837,7 +837,7 @@ non-authors is found, assume that all of the authors match." + + See `notmuch-tag' for information on the format of TAG-CHANGES." + (interactive) +- (apply 'notmuch-tag notmuch-search-query-string tag-changes)) ++ (notmuch-tag notmuch-search-query-string tag-changes)) + + (defun notmuch-search-buffer-title (query) + "Returns the title for a buffer with notmuch search results." +-- +1.8.4.rc3 +