From: Tomi Ollila Date: Mon, 7 Apr 2014 09:22:17 +0000 (+0300) Subject: Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version... X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=49364038c1a6858836fd72069d2c33174c1b99be;p=notmuch-archives.git Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version.el from it --- diff --git a/5f/d14638201905cf2ed5e768057d0cef2f725032 b/5f/d14638201905cf2ed5e768057d0cef2f725032 new file mode 100644 index 000000000..3c31a7e2c --- /dev/null +++ b/5f/d14638201905cf2ed5e768057d0cef2f725032 @@ -0,0 +1,100 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 7B294431FBF + for ; Mon, 7 Apr 2014 02:22:36 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id VmphGEC6OU6H for ; + Mon, 7 Apr 2014 02:22:26 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id C513B431FB6 + for ; Mon, 7 Apr 2014 02:22:25 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 4910D100086; + Mon, 7 Apr 2014 12:22:17 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create + notmuch-version.el from it +In-Reply-To: <87a9by47wh.fsf@maritornes.cs.unb.ca> +References: <1395261431-24668-1-git-send-email-tomi.ollila@iki.fi> + <1395261431-24668-2-git-send-email-tomi.ollila@iki.fi> + <87a9by47wh.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.17+174~gef82849 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 07 Apr 2014 09:22:36 -0000 + +On Sun, Apr 06 2014, David Bremner wrote: + +> Tomi Ollila writes: +> +>> +;; You should have received a copy of the GNU General Public License +>> +;; along with Notmuch. If not, see . +> +> Do you think we need a copyright header in a generated file? + +This is more due to the template-to-file conversion simplicity than need +and I thought there is no harm having the copyright there. At least the +file is consistent with others in that sense. + +>> + +>> +(defconst notmuch-emacs-version %VERSION% +>> + "Version string of this version of Notmuch Emacs MUA.") +>> + +> +> At the risk of being very picky, how about less copies of Version, maybe +> "Version of Notmuch Emacs MUA" + +Actually that is a good point: + +What I put there was modeled after `emacs-version': +"Version numbers of this version of Emacs." + +Then, gnus has (lisp/gnus/gnus.el in emacs sources): + +(defconst gnus-version-number "5.13" + "Version number for this version of Gnus.") + +(defconst gnus-version (format "Gnus v%s" gnus-version-number) + "Version string for this version of Gnus.") + +All of these are of type string, and the documentation states whether +it is (at least close to) numeric or not within string. But there is +no tradition of what *-version should contain. + +Therefore if we say "Version of Notmuch Emacs MUA", it can contain +"0.17+163~gcedea23" "0.18" or "unknown" + + +> Other than that, the series looks OK, and works on Debian now. +> +> d + +Tomi